This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Specify formatter_class=argparse.ArgumentDefaultsHelpFormatter
in generic_parsing.py
to show default values for arguments in help message
#689
Merged
ant0nsc
merged 8 commits into
microsoft:main
from
JacopoTeneggi:jteneggi/print_default_values
Mar 15, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ant0nsc
previously approved these changes
Mar 9, 2022
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hey @JacopoTeneggi , Your change looks good, I forgot that we need to start Azure pipelines manually for external contributions, which I did just now. |
ant0nsc
previously approved these changes
Mar 9, 2022
fepegar
previously approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @JacopoTeneggi!
Hi @ant0nsc sorry to mention directly: I do not have permissions to merge and I see that the check |
@JacopoTeneggi , (no issue about the mentioning, that's helpful really!), I've merged main and will restart the pipelines now. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
fepegar
approved these changes
Mar 15, 2022
ant0nsc
approved these changes
Mar 15, 2022
ant0nsc
approved these changes
Mar 15, 2022
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #675 .
Now, default argument values are shown in the help message, for example:
note that some outputs are empty instead of showing a value of
None
, should this behavior be changed?PR Checklist:
Added/Changed/Removed/... in the "Upcoming" section.
and if needed a motivation why that change was required.