Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix: do not copy host document as it negatively impact performance #2113

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: do not copy host document as it negatively impact performance #2113

merged 1 commit into from
Feb 4, 2025

Conversation

baywet
Copy link
Member

@baywet baywet commented Feb 3, 2025

related #1998

@baywet baywet added this to the v2-Preview6 milestone Feb 3, 2025
@baywet baywet self-assigned this Feb 3, 2025
@baywet baywet enabled auto-merge February 3, 2025 14:32
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@baywet baywet mentioned this pull request Feb 3, 2025
Merged
andrueastman
andrueastman approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@baywet baywet merged commit 1043e4e into dev Feb 4, 2025
13 of 14 checks passed
@baywet baywet deleted the fix/do-not-copy-document branch February 4, 2025 06:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

@irvinesunday irvinesunday Awaiting requested review from irvinesunday

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

@gavinbarron gavinbarron Awaiting requested review from gavinbarron

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@MaggieKimani1 MaggieKimani1 Awaiting requested review from MaggieKimani1

Assignees

@baywet baywet

Labels
None yet
Projects
None yet
Milestone
v2-Preview6
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @andrueastman