-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add support for DotNet Framework 4.0 STIG, Version 1, Release 8 #455
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.3.0 #455 +/- ##
=======================================
Coverage 77.22% 77.22%
=======================================
Files 16 16
Lines 180 180
Branches 3 3
=======================================
Hits 139 139
Misses 38 38
Partials 3 3 Continue to review full report at Codecov.
|
V-81495::For 32-bit systems: HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\.NETFramework\v4.0.30319\::Registry Hive: HKEY_LOCAL_MACHINE | ||
V-81495::For 64 bit systems:::Registry Path: \SOFTWARE\Microsoft\.NETFramework\v4.0.30319\ | ||
V-81495::HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Microsoft\.NETFramework\v4.0.30319\::Type: REG_DWORD | ||
V-81495::If the “SchUseStrongCrypto” value name does not exist, or is not a REG_DWORD type set to “1”, this is a finding.::Value Name: SchUseStrongCrypto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version of this STIG has logfile entries for rule V-30935. Are those no longer valid in the latest version of the STIG?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
running Compare-PowerStigXml:
#TYPE System.Collections.DictionaryEntry
"Name","Key","Value"
"V-18395","V-18395","changed"
"V-30935","V-30935","deleted"
"V-32025","V-32025","deleted"
I believe they no longer apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh I see Nehru's comment below, on the compare results. I'll sync with him
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tony, we are targeting 4.0 for new STIGs. At this point, it may be easier to branch off of 4.0 and regenerate the .Net STIG. I welcome others thoughts here as well.
@togriffith I talked with Brian and its probably best we merge this into 4.0.0, as the 3.3.0 release is in progress. We need to make changes to this PR to accommodate V-30935 (adding entries back to the log file) before we can merge. The initial compare results were inaccurate. |
Thanks @bcwilhite. I'll sync with @nehrua on this. |
re-branching and submitting off of 4.0.0 instead of 3.3.0 |
Pull Request (PR) description:
Add support for DotNet Framework 4.0 STIG, Version 1, Release 8
This Pull Request (PR) fixes the following issues:
Automating two rules and fixing deleted rule issues.
This fixes #447
Task list:
This change is