Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PowerSTIG to pass OrgSettings in a configuration via a hashtable #490

Merged
merged 14 commits into from
Sep 4, 2019

Conversation

bcwilhite
Copy link
Contributor

@bcwilhite bcwilhite commented Aug 29, 2019

Pull Request (PR) description:

Update PowerSTIG to pass OrgSettings in a configuration via a hashtable

This Pull Request (PR) fixes the following issues:

This fixes #372

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

DSCResources/SqlServer/SqlServer.schema.psm1 Outdated Show resolved Hide resolved
DSCResources/WindowsClient/WindowsClient.schema.psm1 Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

Merging #490 into 4.0.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.0.0     #490   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          16       16           
  Lines         198      198           
  Branches        3        3           
=======================================
  Hits          155      155           
  Misses         40       40           
  Partials        3        3
Impacted Files Coverage Δ
...ources/WindowsDefender/WindowsDefender.schema.psm1 80% <ø> (ø) ⬆️
...rces/WindowsDnsServer/WindowsDnsServer.schema.psm1 64.28% <ø> (ø) ⬆️
...CResources/WindowsClient/WindowsClient.schema.psm1 66.66% <ø> (ø) ⬆️
DSCResources/OracleJRE/OracleJRE.schema.psm1 66.66% <ø> (ø) ⬆️
DSCResources/IisSite/IisSite.schema.psm1 81.81% <ø> (ø) ⬆️
...rces/InternetExplorer/InternetExplorer.schema.psm1 71.42% <ø> (ø) ⬆️
DSCResources/FireFox/FireFox.schema.psm1 66.66% <ø> (ø) ⬆️
...CResources/WindowsServer/WindowsServer.schema.psm1 68.42% <ø> (ø) ⬆️
DSCResources/Office/Office.schema.psm1 71.42% <ø> (ø) ⬆️
...ources/DotNetFramework/DotNetFramework.schema.psm1 80% <ø> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a91963c...23c60ef. Read the comment docs.

@bcwilhite bcwilhite merged commit 9a7f134 into 4.0.0 Sep 4, 2019
@bcwilhite bcwilhite deleted the bcwilhite#372 branch September 4, 2019 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants