Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update PowerSTIG to successfully parse/apply Windows 2012 R2 DC Version 2, Rev 21 #677 #687

Closed
wants to merge 6 commits into from
Closed

Update PowerSTIG to successfully parse/apply Windows 2012 R2 DC Version 2, Rev 21 #677 #687

wants to merge 6 commits into from

Conversation

risabara
Copy link
Collaborator

@risabara risabara commented Jul 31, 2020 •
edited by athaynes
Loading

Pull Request (PR) description:
Update PowerSTIG to successfully parse/apply Windows 2012 R2 DC Version 2, Rev 21
This Pull Request (PR) fixes the following issues:

This fixes #677

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@risabara risabara requested a review from bcwilhite July 31, 2020 17:55
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (4.5.0@eabcd3f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             4.5.0   #687   +/-   ##
======================================
  Coverage         ?    57%           
======================================
  Files            ?    126           
  Lines            ?   4278           
  Branches         ?      0           
======================================
  Hits             ?   2441           
  Misses           ?   1837           
  Partials         ?      0

richard.sabaratnamhe and others added 2 commits July 31, 2020 11:38
@bcwilhite bcwilhite requested a review from erjenkin August 3, 2020 13:27
erjenkin
erjenkin suggested changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@erjenkin erjenkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule V-1081, should have an extra setting for CSV as a value according to guidance

@erjenkin
Copy link
Contributor

Change requested never addressed, closing PR

@erjenkin erjenkin closed this Aug 26, 2020
@bcwilhite bcwilhite deleted the risabara#677 branch September 1, 2020 18:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@erjenkin erjenkin erjenkin requested changes

@bcwilhite bcwilhite bcwilhite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@risabara @codecov-commenter @erjenkin @bcwilhite