Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PowerSTIG to successfully parse/apply Adobe Acrobat Reader DC Continuous Track STIG - Ver 2, Rel 1 #929 #930

Merged
merged 6 commits into from
Aug 19, 2021

Conversation

hinderjd
Copy link
Collaborator

@hinderjd hinderjd commented Jul 29, 2021

Pull Request (PR) description:

Update PowerSTIG to successfully parse/apply Adobe Acrobat Reader DC Continuous Track STIG - Ver 2, Rel 1

This Pull Request (PR) fixes the following issues:

Update PowerSTIG to successfully parse/apply Adobe Acrobat Reader DC Continuous Track STIG - Ver 2, Rel 1

This fixes #929

Task list:

  • Change details added to Unreleased section of CHANGELOG.md (Not required for Convert modules)?
  • Added/updated documentation, comment-based help and descriptions where appropriate?
  • Examples appropriately updated?
  • New/changed code adheres to Style Guidelines?
  • Unit and (optional) Integration tests created/updated where possible?

This change is Reviewable

@hinderjd hinderjd added the enhancement New feature or request label Jul 29, 2021
@hinderjd hinderjd added this to the 4.10.0 milestone Jul 29, 2021
@hinderjd hinderjd self-assigned this Jul 29, 2021
<DuplicateOf />
<Ensure>Present</Ensure>
<IsNullOrEmpty>False</IsNullOrEmpty>
<Key>HKEY_LOCAL_MACHINE\Software\Adobe\Acrobat Reader\DC\Installer HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Adobe\Acrobat Reader\DC\Installer</Key>
Copy link
Contributor

@bcwilhite bcwilhite Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path is broken, the direction is to drop the Wow6432Node key path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be broken, there are two keys in this section, should be one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see two keys

<DuplicateOf />
<Ensure>Present</Ensure>
<IsNullOrEmpty>False</IsNullOrEmpty>
<Key>HKEY_LOCAL_MACHINE\Software\Adobe\Acrobat Reader\DC\Installer HKEY_LOCAL_MACHINE\SOFTWARE\Wow6432Node\Adobe\Acrobat Reader\DC\Installer</Key>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be broken, there are two keys in this section, should be one.

@bcwilhite bcwilhite changed the title Parse\Apply Adobe Acrobat Reader DC Continuous Track STIG - Ver 2, Rel 1 #929 Update PowerSTIG to successfully parse/apply Adobe Acrobat Reader DC Continuous Track STIG - Ver 2, Rel 1 #929 Aug 17, 2021
@bcwilhite bcwilhite merged commit 0853d79 into 4.10.0 Aug 19, 2021
@bcwilhite bcwilhite deleted the hinderjd#929 branch August 19, 2021 15:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse\Apply Adobe Acrobat Reader DC Continuous Track STIG - Ver 2, Rel 1
3 participants