[PowerToys Run] Obsolete APIs and warnings introduced in .net5 #12423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed TargetFramework for PowerLauncher project in order to resolve an issue with ModernWpf
mykhailopylyp
added
the
Product-PowerToys Run
yuyoyuppe
approved these changes
Jul 19, 2021
jaimecbernardo
approved these changes
Jul 19, 2021
stefansjfw
approved these changes
Jul 19, 2021
mykhailopylyp
added a commit
that referenced
this pull request
Jul 21, 2021
* [Setup] Add support for installing both dotnet 3 and 5 (#12306) * [PowerToys Run] Update to net5 (#12286) * Change targets of projects * Update Microsoft.Toolkit.Uwp.Notifications, changed TargetFramework for PowerLauncher project in order to resolve an issue with ModernWpf * Specify windows version in order to fix build errors * Fixed suppressed warnings * Updated sdk * Removed usage of obsolete GlobalAssemblyCache * Removed obsolete DesktopNotificationManagerCompat * Update nuget versions * Update installer * [PowerToys Run] Obsolete APIs and warnings introduced in .net5 (#12423) * Change targets of projects * Update Microsoft.Toolkit.Uwp.Notifications, changed TargetFramework for PowerLauncher project in order to resolve an issue with ModernWpf * Fixed suppressed warnings * Removed obsolete DesktopNotificationManagerCompat * Get rid of binary formatter * Update tests * Don't include new image cache file to the report * There's no need to call IsOwner as it doesn't make sense * Fix different nullability exception * Exclude extra dlls from tests Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about:
What is include in the PR:
WoxJsonStorageinstead ofBinaryStorageBinaryStorageandBinaryFormatteras a resultWindow.IsOwnerproperty as it always returns true. That option doesn't make sense because we want to query all windows not only windows created byPowerLauncher.exeprocessImageUsageCache.jsoninto the bug report tool as it is not needed and can be considered as sensitive infoHow does someone test / validate:
ImageUsageCache.jsonis created and populated with valid dataQuality Checklist
Contributor License Agreement (CLA)
A CLA must be signed. If not, go over here and sign the CLA.