Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Settings V2: new FancyZones, ImageResizer XAML, sidepanels are now in the settings pages for more flexibility #1792

Merged
8 commits merged into from
Mar 31, 2020
Merged

Settings V2: new FancyZones, ImageResizer XAML, sidepanels are now in the settings pages for more flexibility #1792

8 commits merged into from
Mar 31, 2020

Conversation

niels9001
Copy link
Contributor

@niels9001 niels9001 commented Mar 31, 2020

Summary of the Pull Request

  • Added a FancyZones XAML page.
  • Added a ImageResizer XAML page.
  • Replaced various ToggleSwitches with CheckBoxes based on industry standard UX guidelines (https://uxmovement.com/buttons/when-to-use-a-switch-or-checkbox/)
  • Added sidepanel with module info and contributors list to all separate pages including visual state management. (And removed the fixed one from ShellPage)

Settingsv3

References

#889

PR Checklist

  • Applies to Fluent UX: Settings #889
  • CLA signed. If not, go over here and sign the CLA
  • [] Tests added/passed
  • [] Requires documentation to be updated
  • [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: [CDPx] fix for makeappx, update SDK for MSI #1373

@niels9001
Copy link
Contributor Author

niels9001 commented Mar 31, 2020

Commit #53 adds am optional placeholder image object in the side panel of FancyZones that could be might be nice to have a gif showing off the feature. Windows 10 settings does this for some features.

@niels9001 niels9001 changed the title User/niels9001/settings v2 uximprovements Settings V2: new FancyZones, ImageResizer XAML, sidepanels are now in the settings pages for more flexibility Mar 31, 2020
@ghost ghost merged commit 432d92b into microsoft:dev/settingsV2 Mar 31, 2020
@mdtauk
Copy link

mdtauk commented Mar 31, 2020

Could I put a request in for a HostBackdrop 80% Acrylic on the sidebar, and extending into the TitleBar Area.

@niels9001
Copy link
Contributor Author

Could I put a request in for a HostBackdrop 80% Acrylic on the sidebar, and extending into the TitleBar Area.

Yes, that would be great to have! Currently this is not possible with XAML Islands (and I think not even with WinUI 3.0 :(): microsoft/microsoft-ui-xaml#2104 (comment)

We're tracking the titlebar issue here (where you already commented in :)): #1547

@mdtauk
Copy link

mdtauk commented Mar 31, 2020

Could I put a request in for a HostBackdrop 80% Acrylic on the sidebar, and extending into the TitleBar Area.

Yes, that would be great to have! Currently this is not possible with XAML Islands (and I think not even with WinUI 3.0 :(): microsoft/microsoft-ui-xaml#2104 (comment)

We're tracking the titlebar issue here (where you already commented in :)): #1547

Ah I didn't realise it would be using a Xaml Island - I guess those things may have to wait until WinUI Desktop gets those features.

ghost pushed a commit that referenced this pull request Apr 7, 2020
… the settings pages for more flexibility (#1792)

* Added FZ settings page

* Added FZ page

* Added sidepanel to all settings pages + UX improvements. New Fancy zones page.

* Added ImageResizer page + sidepanel improvements

* Revert "Added ImageResizer page + sidepanel improvements"

This reverts commit 75bc37a.

* Removed contributors on general page

* Added ImageResizer page
ghost pushed a commit that referenced this pull request Apr 7, 2020
… the settings pages for more flexibility (#1792)

* Added FZ settings page

* Added FZ page

* Added sidepanel to all settings pages + UX improvements. New Fancy zones page.

* Added ImageResizer page + sidepanel improvements

* Revert "Added ImageResizer page + sidepanel improvements"

This reverts commit 75bc37a.

* Removed contributors on general page

* Added ImageResizer page
This pull request was closed.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants