Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update function params and helpers #400

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Update function params and helpers #400

wants to merge 7 commits into from
+144 −130

Conversation

arudell
Copy link
Member

@arudell arudell commented Mar 6, 2025

Description

Summary of changes:

  • changes

Change type

  • Bug fix (non-breaking change)
  • Code style update (formatting, local variables)
  • New Feature (non-breaking change that adds new functionality without impacting existing)
  • Breaking change (fix or feature that may cause functionality impact)
  • Other

Checklist:

  • My code follows the style and contribution guidelines of this project.
  • I have tested and validated my code changes.

sbgms
sbgms reviewed Mar 7, 2025
View reviewed changes
src/modules/SdnDiag.NetworkController.psm1
[Parameter(Mandatory = $false, ParameterSetName = 'Resource')]
[Parameter(Mandatory = $false, ParameterSetName = 'InstanceID')]
[Switch]$ConvertToJson,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: you could use "__AllParameterSets" to avoid adding more.

@sbgms
Copy link
Contributor

sbgms commented Mar 7, 2025 

    Get-SdnVMNetworkAdapterPortProfile -AllVMs

-All ?

Refers to: src/modules/SdnDiag.Server.psm1:2547 in 15ab29c. [](commit_id = 15ab29c, deletion_comment = False)

sbgms
sbgms approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@sbgms sbgms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sbgms sbgms sbgms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arudell @sbgms