Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Fix Platform Detection Logic on Fabric #2234

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Jun 12, 2024

Related Issues/PRs

Based on Internal Bug Reports

What changes are proposed in this pull request?

Fix wrong platform detection result when the utility function is first run in a thread with no spark context access.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@lhrotk lhrotk requested a review from mhamilton723 as a code owner June 12, 2024 07:34
@lhrotk
Copy link
Contributor Author

lhrotk commented Jun 12, 2024

/azp run

Copy link

No pipelines are associated with this pull request.

@lhrotk
Copy link
Contributor Author

lhrotk commented Jun 12, 2024

/azp run

Copy link

No pipelines are associated with this pull request.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (91e552c) to head (7b4e370).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2234      +/-   ##
==========================================
- Coverage   84.42%   84.37%   -0.05%     
==========================================
  Files         327      327              
  Lines       16715    16715              
  Branches     1495     1495              
==========================================
- Hits        14111    14104       -7     
- Misses       2604     2611       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit 440f18e into microsoft:master Jun 15, 2024
59 of 68 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants