Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow underscore in jsx attribute names #655

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Conversation

mjbvz
Copy link
Contributor

@mjbvz mjbvz commented Aug 21, 2018

Fixes #648

@@ -0,0 +1,5 @@
<Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line at the beginning of file to avoid generating ts grammar baseline

// @onlyOwnGrammar - As this has jsx

@sheetalkamat
Copy link
Member

Also add test case for #649

Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix as per feedback

@mjbvz mjbvz merged commit 6de67c7 into microsoft:master Aug 23, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants