rename generic parameters in Exclude<>
#2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making the capabilities / limitations of `Exclude<>` more obvious. see: microsoft/TypeScript#47178
|
Thanks 👍🏻 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR bourne of my own confusion. see: microsoft/TypeScript#47178
I believed that
Exclude<>was capable of, eg,type not0 = Exclude< number, 0 >. When I found this was not the case, I guessed from the examples thatExcludeworks on union types, which seems more or less correct.Very open to better or more correct namings here, but I think
Typeas the first parameter is particularly misleading -Typereads very clearly to me as any type, but Exclude does not work on any type.