Skip to content

tsc should give an error if "typings" in package.json is not a string #4828

Closed
@DanielRosenwasser

Description

@DanielRosenwasser

Courtesy of a long troubleshooting session with @kataras on September 16, 2015.

If you have "typings" in package.json as an array or something instead of a string, we will crash hard:

C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:483
if (path.charCodeAt(0) === 47) {
^
TypeError: path.charCodeAt is not a function
at getRootLength (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:483:18)
at Object.combinePaths (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:643:13)
at loadNodeModuleFromDirectory (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:29439:73)
at loadModuleFromNodeModules (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:29462:26)
at nodeModuleNameResolver (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:29405:20)
at resolveModuleName (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:29385:28)
at C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:29636:115
at Object.map (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:155:29)
at resolveModuleNamesWorker (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:29636:67)
at processImportedModules (C:\Users\Makis-PC\AppData\Roaming\npm\node_modules\typescript\lib\tsc.js:30013:35)

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugA bug in TypeScriptGood First IssueWell scoped, documented and has the green lightHelp WantedYou can do this

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions