Skip to content

Google feedback on TS 5.4-beta #57390

Open
@dloyda

Description

@dloyda

Acknowledgement

  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.

Comment

This GitHub issue contains feedback on the TS 5.4-beta release from the team
that is responsible for keeping Google's internal software working with the
latest version of TypeScript.

Executive summary

  • We do not expect to have significant difficulty in upgrading Google to TS
    5.4.
  • Some changes to our TypeScript code are required to make it compile with TS
    5.4.
  • Detail sections below explain the changes to our code we expect to make to
    unblock the upgrade.

Impact summary

Change description Announced Libraries affected
lib/d.ts changes yes 0.016%
Errors When Type-Only Imports Conflict with yes 0.0004%

The Announced column indicates whether we were able to connect the observed
change with a section in the
TS5.4-beta announcement.

The following sections give more detailed explanations of the changes listed
above.

Changes which were announced

lib/d.ts Changes

We support the typing improvements. Generally it's clear what's changing and the
changes seems minimal this time.

For the TSC changes, we expect to fix our codebase to comply to the new API and
for other typing changes, we expect to // @ts-ignore to silence the errors.

We observed the following types of errors:

  • TS2345: Argument of type X is not assignable to parameter of type Y
    • .005% of libraries affected
  • TS2769: No overload matches this call.
    • .001% of libraries affected
  • TS2322: Type X is not assignable to type Y.
    • .003% of libraries affected
  • TS2344: Type X does not satisfy the constraint Y.
    • .001% of libraries affected
  • TS2552: Cannot find name X. Did you mean Y?
    • .001% of libraries affected
  • TS2430: Interface X incorrectly extends interface Y.
    • .001% of libraries affected
  • TS2339: Property X does not exist on type Y.
    • .001% of libraries affected

Metadata

Metadata

Assignees

No one assigned

    Labels

    DiscussionIssues which may not have code impact

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions