Fix stack overflow in indexed access relation #14874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Type 'T' is not assignable to type 'U'. | ||
| Type 'T[keyof T]' is not assignable to type 'U[string]'. | ||
| Type 'T[string]' is not assignable to type 'U[string]'. | ||
| Type 'T' is not assignable to type 'U'. |
There was a problem hiding this comment.
Is there any way to not do this? Going around in circles here: 'T' is not assignable to type 'U'. because 'T' is not assignable to type 'U'. because 'T' is not assignable to type 'U'.
There was a problem hiding this comment.
Our error elaboration scheme works well when we drill down along a single path, but sometimes that isn't the case. In this particular example we're drilling down three paths, each of which end with T not being assignable to U. We could attempt to eliminate paths that have already been elaborated from the error reporting (perhaps by simply dropping elaborations that are already present in the diagnostic chain), but that's really an issue that is orthogonal to this PR.
mhegazy
approved these changes
Mar 27, 2017
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14723.