Skip to content

[release-3.3] Supports incremental build in tsc --b --w mode #29467

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 17, 2019
Merged

[release-3.3] Supports incremental build in tsc --b --w mode #29467

merged 21 commits into from
Jan 17, 2019

Conversation

sheetalkamat
Copy link
Member

Port #29161 to release-3.3

@sheetalkamat
Use watch factory instead of direct host functions in tsbuild to prov…
8d2c359 
…ide detailed information on watch invokations
@sheetalkamat
Make BuilderProgram as Program
9fcfa28
@sheetalkamat
Make SolutionBuilder handle BuilderProgram in preparation to handle i…
5d6ecb5 
…ncremental builds
@sheetalkamat
Revert BuilderProgram to be redirected object to Program in preparati…
900dc8c 
…on to set Program in state to undefined for storing.
@sheetalkamat
Add method to release held Program in BuilderProgram
b6e6b99
@sheetalkamat
Use oldProgram to create the new Program.
2d712e3 
This helps in storing the semantic diagnostics
@sheetalkamat
Use emit builder to emit only changed files.
6be4439
@sheetalkamat
Update the timestamps of outputs that dont need to be written because…
e00df32 
… of incremental build

This ensures that after `tsbuild` after incremental build of `tsbuild -w` doesnt result in unnecessary rebuilds
@sheetalkamat
Handle prepend in incremental build. Always emit when program uses pr…
122339b 
…oject reference with prepend since it cant tell changes in js/map files
@sheetalkamat
Write the tests for incremental build and declaration emit errors han…
82f8411 
…dling

These will fail since its still TODO
@sheetalkamat
Handle declaration emit errors in tsbuild mode by backing up builder …
75e2e2e 
…state

This helps us revert to state where we pretend as if emit is not done (since we do not do emit if there are errors)
@sheetalkamat
Use DirectoryStructureHost for fileExists and readFile
66018ea
@sheetalkamat
Fix typo
1470a7c
@sheetalkamat
Rename indexing variable
19cec03
@sheetalkamat
CompilerHostLikeForCache rename
72069a7
@sheetalkamat
Fix typo
2b97802
@sheetalkamat
Fix typo
dcce3c3
@sheetalkamat
PR feedback
0427ad0
@sheetalkamat
PR feedback
5a368ae
@sheetalkamat
add missing type annotation
a93b51a
@sheetalkamat
renames
3921921
@sheetalkamat sheetalkamat changed the base branch from master to release-3.3 January 17, 2019 22:04
@sheetalkamat sheetalkamat merged commit e8ca5b0 into release-3.3 Jan 17, 2019
@sheetalkamat sheetalkamat deleted the incrementalBuild33 branch January 17, 2019 23:18
@Bnaya
Copy link

Bnaya commented Jan 18, 2019

Something that i couldnt figure out from tracking the variues issues:
Dose tsc build supports having different lib settings per project? (Full program isolation)

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sandersn sandersn sandersn approved these changes

@DanielRosenwasser DanielRosenwasser Awaiting requested review from DanielRosenwasser

@weswigham weswigham Awaiting requested review from weswigham

@rbuckton rbuckton Awaiting requested review from rbuckton

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sheetalkamat @Bnaya @sandersn