fix(lib/es2019): Symbol.description may be undefined
#36263
Merged
+924
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExE-Boss
requested review from
DanielRosenwasser,
rbuckton,
RyanCavanaugh,
sandersn and
weswigham
ljharb
approved these changes
Jan 19, 2020
|
@typescript-bot test this |
|
Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 5aafd26. You can monitor the build here. It should now contribute to this PR's status checks. |
|
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 5aafd26. You can monitor the build here. It should now contribute to this PR's status checks. |
|
The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master. |
RyanCavanaugh
approved these changes
Jan 24, 2020
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Symbol.prototype.descriptiongetter may returnundefined, because the constructor allowsundefineddescriptions.