Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(36266): async function needs Promise<T> return type quick fix #36654

Merged
merged 2 commits into from
May 4, 2020
Merged

feat(36266): async function needs Promise<T> return type quick fix #36654

merged 2 commits into from
May 4, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #36266

@sandersn sandersn added the For Milestone Bug PRs that fix a bug with a specific milestone label Feb 14, 2020
@a-tarasyuk a-tarasyuk requested review from DanielRosenwasser and elibarzilay and removed request for elibarzilay and DanielRosenwasser February 24, 2020 18:54
ExE-Boss
ExE-Boss suggested changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@ExE-Boss ExE-Boss left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PromiseLike<foo> should get auto‑fixed to Promise<foo> instead of the current Promise<PromiseLike<foo>>, which is incorrect: #27711.

@a-tarasyuk a-tarasyuk force-pushed the feature/36266 branch 3 times, most recently from a813d63 to f90d850 Compare March 28, 2020 19:18
@ExE-Boss
Copy link
Contributor

This should probably also have some tests for non‑void custom PromiseLikes.

@elibarzilay elibarzilay force-pushed the feature/36266 branch 2 times, most recently from b54313e to 2f0e50c Compare May 4, 2020 16:53
@elibarzilay
Make getAwaitedType private
889e82b 
Also, fix an additional baseline change and break up huge line.
@elibarzilay elibarzilay merged commit ba02f43 into microsoft:master May 4, 2020
@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-3.9

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 5, 2020 •
edited
Loading

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-3.9 on this PR at 889e82b. You can monitor the build here.

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request May 5, 2020
@elibarzilay @typescript-bot
Cherry-pick PR microsoft#36654 into release-3.9
650a176 
Component commits:
766a201 feat(36266): add a quick fix for incorrect return types in async functions

889e82b Make `getAwaitedType` private
Also, fix an additional baseline change and break up huge line.
@typescript-bot typescript-bot mentioned this pull request May 5, 2020
Closed
@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I've opened #38337 for you.

@jakebailey jakebailey mentioned this pull request Aug 16, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@DanielRosenwasser DanielRosenwasser DanielRosenwasser left review comments

@ExE-Boss ExE-Boss ExE-Boss requested changes

@elibarzilay elibarzilay elibarzilay approved these changes

Assignees

@elibarzilay elibarzilay

Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async function needs Promise<T> return type quick fix
6 participants
@a-tarasyuk @ExE-Boss @DanielRosenwasser @typescript-bot @elibarzilay @sandersn