Skip to content

Enhancement new expression with type arguments without parenthesized argument list error message #37576

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 5 commits into from
Mar 25, 2020

Conversation

0xPoe
Copy link

@0xPoe 0xPoe commented Mar 25, 2020

Signed-off-by: Rustin-Liu rustin.liu@gmail.com

Fixes #37523

…argument list error message

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@msftclas
Copy link

msftclas commented Mar 25, 2020

CLA assistant check
All CLA requirements met.

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@0xPoe 0xPoe marked this pull request as ready for review March 25, 2020 04:04
0xPoe added 2 commits March 25, 2020 12:25
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@@ -17,4 +17,4 @@ var C = /** @class */ (function () {
}
return C;
}());
var c = new C(); // parse error
var c = new C; // parse error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a difference here because we no longer create a missing argument list. I think that's probably fine.

@DanielRosenwasser DanielRosenwasser merged commit 8615eec into microsoft:master Mar 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should a new expression with type arguments need parentheses?
3 participants