Emit build info even on noEmitOnError or tsc --build #38853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
requested review from
weswigham,
RyanCavanaugh,
sandersn and
andrewbranch
weswigham
approved these changes
Jun 1, 2020
.../watchMode/programUpdates/reportErrors/when-preserveWatchOutput-is-passed-on-command-line.js
Show resolved
Hide resolved
| ) { | ||
| const canEmitBuildInfo = !(buildResult & BuildResultFlags.SyntaxErrors) && program && !outFile(program.getCompilerOptions()); |
There was a problem hiding this comment.
Why do syntax errors block a build info?
There was a problem hiding this comment.
Because there is nothing to write in this case. Only semantic errors are cached so there is no use writing tsbuildinfo in this case
sheetalkamat
force-pushed
the
noEmitOnError
branch
from
63b3ae4 to
7eeaf64
Compare
cangSDARM
added a commit
to cangSDARM/TypeScript
that referenced
this pull request
Jun 5, 2020
* upstream/master: (48 commits) Fix merging of JS value & TS type decl LEGO: check in for master to temporary branch. `getSymbolDisplayPartsDocumentationAndSymbolKind`: use actual `symbol.flags` for `getAliasedSymbol` LEGO: check in for master to temporary branch. LEGO: check in for master to temporary branch. Fix two tests Update user baselines LEGO: check in for master to temporary branch. address PR comments Emit build info even on noEmitOnError or tsc --build (microsoft#38853) Some changes to tsc baselines for clarity (microsoft#38850) LEGO: check in for master to temporary branch. fix merge conflicts polish tests remove outdated tests convert import trigger reason test convert import trigger reason only convert export trigger reason test convert export cursor only changes remove declaration ...
5 tasks
5 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change the caching of semantic diagnostics in the builder is written to the disk with .tsbuildinfo so next incremental build should benefit from that.