Skip to content

Avoid effect of element access expression #39174

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

Avoid effect of element access expression #39174

merged 3 commits into from
Jun 26, 2020

Conversation

Kingwl
Copy link
Contributor

@Kingwl Kingwl commented Jun 20, 2020

Fixes #39172

@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 20, 2020

@evanw Fix Available here.

@RyanCavanaugh RyanCavanaugh requested a review from rbuckton June 22, 2020 18:23
@Kingwl
Copy link
Contributor Author

Kingwl commented Jun 25, 2020

IMO, It's better if this one can include in the beta release.

@rbuckton rbuckton merged commit 6b4d0bf into microsoft:master Jun 26, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request Jun 28, 2020
@cangSDARM
Merge remote-tracking branch 'upstream/master'
34fb1d2 
* upstream/master:
  LEGO: check in for master to temporary branch.
  Preserve newlines between try/catch/finally, if/else, do/while (microsoft#39280)
  not narrow static property without type annotation in constructor. (microsoft#39252)
  Switch to ES Map/Set internally (microsoft#33771)
  fix(38840): omit completions for a spread like argument in a function definition (microsoft#38897)
  fix(38785): include in NavigationBar child items from default exported functions (microsoft#38915)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Avoid effect of element access expression (microsoft#39174)
  Update typescript-eslint to 3.4.1-alpha.1 (microsoft#39260)
  Handle 'keyof' for generic tuple types (microsoft#39218)
  Disable unsound T[K] rule in subtype relations (microsoft#39249)
  LEGO: check in for master to temporary branch.
  Upgrade typescript-eslint version (microsoft#39242)
  Handle recursive type references up to a certain level of expansion in inference (microsoft#38011)
  Do not consider binding patterns in contextual types for return type inference where all the signature type parameters have defaults (microsoft#39081)
  LEGO: check in for master to temporary branch.

# Conflicts:
#	src/compiler/program.ts
#	src/compiler/types.ts
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rbuckton rbuckton rbuckton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Side effect bugs with logical assignment
2 participants
@Kingwl @rbuckton