--noImplicitOverride #39669
Merged
--noImplicitOverride #39669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@typescript-bot run dt. |
|
Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
typescript-bot
added
the
For Uncommitted Bug
|
Emmmm.... Need review and feedback |
|
@typescript-bot pack this. |
|
Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
|
@typescript-bot pack this. |
|
Might have a small regression caused by additional check, i guess. |
|
Yeah, I doubt we'll see anything significant, and I will likely merge if it's not too crazy seeing as we can optimize later. |
|
@DanielRosenwasser Here they are:Comparison Report - master..39669
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
The benchmark looks good, at least with the option off. |
DanielRosenwasser
approved these changes
Mar 26, 2021
|
@DanielRosenwasser Here they are:Comparison Report - master..39669
System
Hosts
Scenarios
Developer Information: |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Is this expected? For code class Q {
y() {}
}
class T extends Q {
override y() {}
}The nightly playground emits the following JS code "use strict";
class Q {
y() { }
}
class T extends Q {
override y() { }
}which IMO is invalid. Is |
|
@Jack-Works Nope. Fixed in #43536. |
|
The compiler is complaining about the missing override keyword for constructor declared properties but it doesn't allow using the modifier on the constructor too. |
|
@danfma can you give an example? |
|
Yes. On the left side, it's the original code. So, I tried to put the override in the constructor like We had to use like in the right side to force the compiler to accept the code.
|
|
Would we consider to add quickfix for parameter property or allow override in parameter property as @danfma said.😂 |
|
By the way, this language feature fits me very well because I'm using an AST transformer to apply some Mobx decorators, and one of these modifiers is the “override” decorator! So, I can read the modifier and translate the code to what Mobx needs! Thus, thank you! 😬 |
|
@Kingwl I think we’re going to allow |
|
Okay. Looking forward for the good news :XP |
|
I've problems with static fields and override: #43916 |
|
What about methods that implement interface (as opposed to base class) members? |
No plan yet. |
|
Is there a way to apply this to my entire project except to classes that inherit from a particular class (like |
|
Same question/need as @guilhermesimoes - getting errors on without a way to exclude these (either by name, e.g. I realize that the TS team is not likely to want to have React-specific things in its codebase, but I just wanted to bring more attention to a common pain point with this feature for a subset of your users :) Example errors for reference: ERROR in src/SomeComponent/index.tsx:22:3
TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Component<IProps, IState, any>'.
20 | IState
21 | > {
> 22 | state: IState = {}
| ^^^^^
23 |
24 | render() {
ERROR in src/SomeComponent/index.tsx:24:3
TS4114: This member must have an 'override' modifier because it overrides a member in the base class 'Component<IProps, IState, any>'.
22 | state: IState = {}
23 |
> 24 | render() {
| ^^^^^^
25 | return ( |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #38905 , #9034
Fixes #2000
This pr added the
overridekeyword to mark the class method is overrides a method in the base class.And a flag called
noImplicitOverrideand don't break something.Basically, If the flag turns on, We add the below check.
used without
noImplicitOverrideflag: ok but less checkIf a class member has override modifier and the container class does not extend any class: error
if a class member has override modifier and the name of the method is not existed in the base class: error
if a class member do not has override modifier and the name of the method is exited in the base class: error
properties are the same as the method.
node in ambient context: not check.
must before accessibility modifier
cannot be used with the
declarestaticmodifier.cannot be used with a constructor.
Something needs to consider:
class declaration in Ambient context. Should we issue errors in the d.ts files?As Suggestion Backlog Slog, 6/8/2016 #9034 said. Looks needn't.abstract method or abstract class:
eg:
eg: