Add flag to change `catch` variables' default types to `unknown` #41013

DanielRosenwasser · 2020-10-09T15:43:27Z

This change adds a new flag called useUnknownInCatchVariables which changes the default type of catch clause variables from any (today's existing behavior) to unknown.

More specifically, under this flag, the following code

try {
  // ...
}
catch (err) {
  console.log(err.message);
}

would become equivalent to

try {
  // ...
}
catch (err: unknown) {
  console.log(err.message); // error: Property 'message' does not exist on type 'unknown'.
}

As a result, a user would receive the following error message from TypeScript:

Property 'message' does not exist on type 'unknown'.

To mitigate this, a user could explicitly perform runtime checks

try {
  // ...
}
catch (err) {
  // First check if we have an Error
  if (err instanceof Error) {
    console.log(err.message);
  }
}

or if that is too painful, a user could use a type assertion to any, or provide an explicit annotation on the catch clause variable with the type any to revert to the old default behavior.

try {
  // ...
}
catch (err: any) {
  console.log(err.message);
}

Fixes #41016.

typescript-bot · 2020-12-02T21:19:09Z

The TypeScript team hasn't accepted the linked issue #41016. If you can get it accepted, this PR will have a better chance of being reviewed.

johnnyreilly · 2021-02-10T07:37:28Z

It would be awesome if strict also enabled this flag; is that likely? (It's possible that this change does that already; but I'm on my phone so it's hard to tell 😅)

DanielRosenwasser · 2021-05-05T22:19:56Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2021-05-05T22:19:59Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at a32013b. You can monitor the build here.

typescript-bot · 2021-05-05T22:19:59Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at a32013b. You can monitor the build here.

typescript-bot · 2021-05-05T22:19:59Z

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at a32013b. You can monitor the build here.

typescript-bot · 2021-05-05T22:19:59Z

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at a32013b. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-05-05T22:19:59Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at a32013b. You can monitor the build here.

typescript-bot · 2021-05-05T22:42:57Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/102337/artifacts?artifactName=tgz&fileId=CB39C963580F3F2B857D3171C4A6770212DE0222B86B618B209B2F4B2E12A36B02&fileName=/typescript-4.3.0-insiders.20210505.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.3.0-pr-41013-8".;

typescript-bot · 2021-05-05T22:55:51Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41013

_Metric	_master	₄₁₀₁₃	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{344,651k (± 0.02%)}	_{344,706k (± 0.03%)}	_{+54k (+ 0.02%)}	_344,444k	_344,928k
_{Parse Time}	_{1.91s (± 0.55%)}	_{1.90s (± 0.43%)}	_{-0.01s (- 0.52%)}	_1.89s	_1.92s
_{Bind Time}	_{0.84s (± 0.57%)}	_{0.84s (± 0.57%)}	_{0.00s ( 0.00%)}	_0.83s	_0.85s
_{Check Time}	_{5.25s (± 0.47%)}	_{5.25s (± 0.31%)}	_{+0.00s (+ 0.06%)}	_5.23s	_5.29s
_{Emit Time}	_{5.89s (± 0.38%)}	_{5.91s (± 1.20%)}	_{+0.02s (+ 0.36%)}	_5.80s	_6.16s
_{Total Time}	_{13.89s (± 0.29%)}	_{13.91s (± 0.58%)}	_{+0.02s (+ 0.12%)}	_13.78s	_14.15s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{200,759k (± 0.03%)}	_{200,821k (± 0.03%)}	_{+62k (+ 0.03%)}	_200,671k	_200,923k
_{Parse Time}	_{0.79s (± 0.51%)}	_{0.78s (± 0.97%)}	_{-0.01s (- 0.63%)}	_0.77s	_0.80s
_{Bind Time}	_{0.53s (± 1.27%)}	_{0.52s (± 0.91%)}	_{-0.00s (- 0.76%)}	_0.51s	_0.53s
_{Check Time}	_{7.59s (± 0.57%)}	_{7.59s (± 0.65%)}	_{-0.00s (- 0.05%)}	_7.47s	_7.72s
_{Emit Time}	_{2.51s (± 1.43%)}	_{2.48s (± 0.90%)}	_{-0.03s (- 1.12%)}	_2.43s	_2.52s
_{Total Time}	_{11.42s (± 0.47%)}	_{11.38s (± 0.53%)}	_{-0.04s (- 0.36%)}	_11.24s	_11.56s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{341,715k (± 0.01%)}	_{341,688k (± 0.02%)}	_{-27k (- 0.01%)}	_341,565k	_341,920k
_{Parse Time}	_{1.56s (± 0.50%)}	_{1.57s (± 0.61%)}	_{+0.01s (+ 0.38%)}	_1.54s	_1.59s
_{Bind Time}	_{0.74s (± 0.78%)}	_{0.74s (± 0.98%)}	_{-0.00s (- 0.13%)}	_0.73s	_0.76s
_{Check Time}	_{5.38s (± 0.34%)}	_{5.38s (± 0.52%)}	_{-0.00s (- 0.02%)}	_5.31s	_5.45s
_{Emit Time}	_{3.02s (± 0.86%)}	_{3.01s (± 0.75%)}	_{-0.01s (- 0.20%)}	_2.97s	_3.06s
_{Total Time}	_{10.70s (± 0.39%)}	_{10.70s (± 0.45%)}	_{-0.00s (- 0.05%)}	_10.59s	_10.80s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{304,178k (± 0.03%)}	_{304,226k (± 0.02%)}	_{+48k (+ 0.02%)}	_304,099k	_304,366k
_{Parse Time}	_{1.22s (± 0.55%)}	_{1.21s (± 0.48%)}	_{-0.00s (- 0.33%)}	_1.20s	_1.23s
_{Bind Time}	_{0.71s (± 0.78%)}	_{0.71s (± 1.03%)}	_{-0.00s (- 0.56%)}	_0.69s	_0.72s
_{Check Time}	_{4.79s (± 0.42%)}	_{4.80s (± 0.47%)}	_{+0.01s (+ 0.23%)}	_4.73s	_4.84s
_{Emit Time}	_{3.21s (± 1.33%)}	_{3.18s (± 1.60%)}	_{-0.03s (- 1.00%)}	_3.03s	_3.27s
_{Total Time}	_{9.93s (± 0.53%)}	_{9.90s (± 0.66%)}	_{-0.02s (- 0.24%)}	_9.76s	_10.03s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{474,572k (± 0.02%)}	_{474,591k (± 0.01%)}	_{+19k (+ 0.00%)}	_474,488k	_474,712k
_{Parse Time}	_{1.94s (± 0.79%)}	_{1.94s (± 0.41%)}	_{-0.00s (- 0.10%)}	_1.92s	_1.96s
_{Bind Time}	_{0.65s (± 1.23%)}	_{0.65s (± 0.80%)}	_{-0.00s (- 0.15%)}	_0.64s	_0.66s
_{Check Time}	_{14.81s (± 0.66%)}	_{14.76s (± 0.64%)}	_{-0.06s (- 0.39%)}	_14.63s	_15.10s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{17.41s (± 0.63%)}	_{17.35s (± 0.54%)}	_{-0.06s (- 0.35%)}	_17.24s	_17.70s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{322,324k (± 0.02%)}	_{322,310k (± 0.02%)}	_{-14k (- 0.00%)}	_322,163k	_322,427k
_{Parse Time}	_{1.91s (± 0.63%)}	_{1.91s (± 0.66%)}	_{-0.00s (- 0.05%)}	_1.88s	_1.94s
_{Bind Time}	_{0.82s (± 0.73%)}	_{0.82s (± 0.70%)}	_{-0.00s (- 0.61%)}	_0.81s	_0.84s
_{Check Time}	_{5.17s (± 0.48%)}	_{5.14s (± 0.42%)}	_{-0.03s (- 0.52%)}	_5.11s	_5.21s
_{Emit Time}	_{6.16s (± 0.82%)}	_{6.15s (± 0.87%)}	_{-0.02s (- 0.24%)}	_6.06s	_6.27s
_{Total Time}	_{14.07s (± 0.49%)}	_{14.02s (± 0.46%)}	_{-0.05s (- 0.35%)}	_13.91s	_14.21s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{187,812k (± 0.14%)}	_{188,033k (± 0.15%)}	_{+221k (+ 0.12%)}	_187,234k	_188,396k
_{Parse Time}	_{0.77s (± 0.62%)}	_{0.77s (± 0.84%)}	_{-0.01s (- 0.65%)}	_0.76s	_0.78s
_{Bind Time}	_{0.53s (± 0.89%)}	_{0.53s (± 0.98%)}	_{-0.00s (- 0.19%)}	_0.52s	_0.54s
_{Check Time}	_{7.04s (± 0.64%)}	_{7.02s (± 0.42%)}	_{-0.02s (- 0.30%)}	_6.98s	_7.10s
_{Emit Time}	_{2.49s (± 1.00%)}	_{2.47s (± 1.28%)}	_{-0.02s (- 1.00%)}	_2.43s	_2.57s
_{Total Time}	_{10.84s (± 0.63%)}	_{10.79s (± 0.32%)}	_{-0.05s (- 0.49%)}	_10.69s	_10.85s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{324,057k (± 0.02%)}	_{324,057k (± 0.01%)}	_{+0k (+ 0.00%)}	_323,992k	_324,106k
_{Parse Time}	_{1.54s (± 0.71%)}	_{1.54s (± 0.87%)}	_{+0.00s (+ 0.19%)}	_1.52s	_1.58s
_{Bind Time}	_{0.72s (± 1.20%)}	_{0.72s (± 0.62%)}	_{-0.00s (- 0.55%)}	_0.71s	_0.73s
_{Check Time}	_{5.20s (± 0.29%)}	_{5.21s (± 0.63%)}	_{+0.01s (+ 0.23%)}	_5.13s	_5.28s
_{Emit Time}	_{3.06s (± 0.70%)}	_{3.06s (± 1.26%)}	_{-0.00s (- 0.03%)}	_3.02s	_3.21s
_{Total Time}	_{10.52s (± 0.33%)}	_{10.54s (± 0.60%)}	_{+0.01s (+ 0.12%)}	_10.41s	_10.72s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{288,711k (± 0.01%)}	_{288,704k (± 0.01%)}	_{-7k (- 0.00%)}	_288,622k	_288,776k
_{Parse Time}	_{1.21s (± 0.78%)}	_{1.21s (± 0.43%)}	_{-0.00s (- 0.16%)}	_1.20s	_1.22s
_{Bind Time}	_{0.70s (± 1.16%)}	_{0.69s (± 0.86%)}	_{-0.01s (- 1.14%)}	_0.68s	_0.71s
_{Check Time}	_{4.70s (± 0.61%)}	_{4.70s (± 0.45%)}	_{-0.00s (- 0.04%)}	_4.66s	_4.75s
_{Emit Time}	_{3.18s (± 1.55%)}	_{3.17s (± 0.46%)}	_{-0.01s (- 0.35%)}	_3.14s	_3.21s
_{Total Time}	_{9.80s (± 0.64%)}	_{9.78s (± 0.24%)}	_{-0.02s (- 0.22%)}	_9.73s	_9.83s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{452,433k (± 0.05%)}	_{452,478k (± 0.01%)}	_{+45k (+ 0.01%)}	_452,351k	_452,672k
_{Parse Time}	_{1.94s (± 0.38%)}	_{1.95s (± 0.37%)}	_{+0.01s (+ 0.52%)}	_1.93s	_1.96s
_{Bind Time}	_{0.64s (± 0.63%)}	_{0.64s (± 1.17%)}	_{-0.00s (- 0.31%)}	_0.63s	_0.66s
_{Check Time}	_{13.30s (± 0.52%)}	_{13.26s (± 0.40%)}	_{-0.04s (- 0.32%)}	_13.15s	_13.41s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.88s (± 0.43%)}	_{15.84s (± 0.36%)}	_{-0.04s (- 0.23%)}	_15.73s	_15.99s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{321,052k (± 0.01%)}	_{321,051k (± 0.00%)}	_{-2k (- 0.00%)}	_321,024k	_321,066k
_{Parse Time}	_{1.90s (± 0.66%)}	_{1.90s (± 0.53%)}	_{+0.00s (+ 0.11%)}	_1.89s	_1.93s
_{Bind Time}	_{0.87s (± 0.66%)}	_{0.87s (± 0.51%)}	_{+0.00s (+ 0.23%)}	_0.86s	_0.88s
_{Check Time}	_{5.15s (± 0.44%)}	_{5.16s (± 0.46%)}	_{+0.00s (+ 0.08%)}	_5.08s	_5.20s
_{Emit Time}	_{6.19s (± 0.64%)}	_{6.22s (± 0.75%)}	_{+0.03s (+ 0.52%)}	_6.10s	_6.33s
_{Total Time}	_{14.11s (± 0.28%)}	_{14.15s (± 0.45%)}	_{+0.04s (+ 0.29%)}	_14.02s	_14.31s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{188,505k (± 0.64%)}	_{188,815k (± 0.62%)}	_{+310k (+ 0.16%)}	_186,850k	_190,136k
_{Parse Time}	_{0.80s (± 0.59%)}	_{0.80s (± 0.56%)}	_{+0.00s (+ 0.25%)}	_0.79s	_0.81s
_{Bind Time}	_{0.55s (± 0.62%)}	_{0.55s (± 0.62%)}	_{0.00s ( 0.00%)}	_0.55s	_0.56s
_{Check Time}	_{7.13s (± 0.47%)}	_{7.16s (± 0.72%)}	_{+0.03s (+ 0.36%)}	_7.09s	_7.29s
_{Emit Time}	_{2.49s (± 0.83%)}	_{2.48s (± 0.63%)}	_{-0.01s (- 0.44%)}	_2.45s	_2.52s
_{Total Time}	_{10.98s (± 0.36%)}	_{10.99s (± 0.49%)}	_{+0.01s (+ 0.11%)}	_10.92s	_11.14s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{323,144k (± 0.01%)}	_{323,129k (± 0.01%)}	_{-15k (- 0.00%)}	_323,075k	_323,158k
_{Parse Time}	_{1.57s (± 0.70%)}	_{1.57s (± 0.64%)}	_{+0.01s (+ 0.38%)}	_1.55s	_1.60s
_{Bind Time}	_{0.75s (± 0.77%)}	_{0.75s (± 0.60%)}	_{-0.00s (- 0.27%)}	_0.74s	_0.76s
_{Check Time}	_{5.19s (± 0.30%)}	_{5.17s (± 0.45%)}	_{-0.01s (- 0.19%)}	_5.14s	_5.24s
_{Emit Time}	_{3.13s (± 0.67%)}	_{3.11s (± 0.68%)}	_{-0.02s (- 0.61%)}	_3.08s	_3.17s
_{Total Time}	_{10.63s (± 0.23%)}	_{10.61s (± 0.38%)}	_{-0.02s (- 0.23%)}	_10.54s	_10.74s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{287,663k (± 0.01%)}	_{287,670k (± 0.01%)}	_{+7k (+ 0.00%)}	_287,626k	_287,720k
_{Parse Time}	_{1.27s (± 1.48%)}	_{1.27s (± 1.21%)}	_{-0.00s (- 0.08%)}	_1.23s	_1.30s
_{Bind Time}	_{0.72s (± 1.17%)}	_{0.72s (± 0.81%)}	_{-0.00s (- 0.55%)}	_0.71s	_0.73s
_{Check Time}	_{4.70s (± 0.38%)}	_{4.73s (± 0.45%)}	_{+0.03s (+ 0.55%)}	_4.67s	_4.77s
_{Emit Time}	_{3.26s (± 0.40%)}	_{3.29s (± 0.83%)}	_{+0.03s (+ 0.80%)}	_3.23s	_3.38s
_{Total Time}	_{9.95s (± 0.27%)}	_{10.00s (± 0.47%)}	_{+0.05s (+ 0.48%)}	_9.92s	_10.11s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{450,697k (± 0.00%)}	_{450,711k (± 0.01%)}	_{+14k (+ 0.00%)}	_450,646k	_450,831k
_{Parse Time}	_{2.00s (± 0.62%)}	_{1.98s (± 1.10%)}	_{-0.02s (- 0.80%)}	_1.93s	_2.03s
_{Bind Time}	_{0.70s (± 0.74%)}	_{0.70s (± 0.85%)}	_{-0.00s (- 0.43%)}	_0.69s	_0.71s
_{Check Time}	_{13.61s (± 0.91%)}	_{13.41s (± 0.66%)}	_{-0.20s (- 1.48%)}	_13.16s	_13.55s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.31s (± 0.76%)}	_{16.09s (± 0.65%)}	_{-0.22s (- 1.32%)}	_15.78s	_16.28s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-206-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{7 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₁₀₁₃	₁₀
_Baseline	_master	₁₀

Developer Information:

Download Benchmark

sandersn

commandLineParser entry should make the new flag a strict one, I think.

src/compiler/commandLineParser.ts

tests/baselines/reference/controlFlowForCatchAndFinally.types

sandersn · 2021-05-18T14:41:24Z

tests/cases/compiler/useUnknownInCatchVariables01.ts

@@ -0,0 +1,35 @@
+// @useUnknownInCatchVariables: true


except for this, I'm not convinced we even need a new test, since we know that unknown narrows, and from some other tests, that strict changes the type of the catch variable to unknown.

I guess there's nothing to change here, except possibly dropping the narrowing tests from this test.

I added that style of code in because most of the purpose of this feature is to ensure that catch variables are narrowed, and that we error on usages if a user doesn't do so.

gvanrossum · 2021-05-18T23:14:38Z

Meta: I was confused by the initial comment, because I wasn't familiar with unknown. I'd say that the first snippet, with catch (err) should not have a comment indicating the error (because IIUC without the new flag it doesn't produce an error), and the second snippet, with explicit catch (err: unknown) should have the error comment, because even without the new flag that's an error. (Right?)

DanielRosenwasser · 2021-05-19T07:40:36Z

@gvanrossum good call, thanks! Must have been an earlier copy/paste error.

sandersn

👍🏼 Does what we talked about in the design meeting.

Side note: It's a little worrying that we don't already have more tests with both (1) catch and (2) strict: true.

Fixes the `no-throw-literal` rule configuration for TypeScript by enabling the appropriate rule in the TypeScript config, per [documentation](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-throw-literal.md#how-to-use). This is timely due to recent [changes to TypeScript](microsoft/TypeScript#41013).

Typescript 4.x changes the default behaviour of try catch and its err type from `any` to [`unknown`](microsoft/TypeScript#41013). This change ensures that where we rely on said variable it is cast accordingly as an `Error`.

* build(deps): update dependency typescript to v4.4.2 * fix(web): cast try catch err type to error Typescript 4.x changes the default behaviour of try catch and its err type from `any` to [`unknown`](microsoft/TypeScript#41013). This change ensures that where we rely on said variable it is cast accordingly as an `Error`. Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Amir Zarrinkafsh <nightah@me.com>

pvinis · 2021-09-23T09:45:21Z

Is there a way to type a function that it throws specific types? So that catch could know what to expect.

Like a func that can throw MyError, and then catch knows that e is MyError.

guilhermesimoes · 2021-11-05T20:18:49Z

Should the flag useUnknownInCatchVariables also affect the return type of Promise.prototype.catch?

https://www.typescriptlang.org/play?strict=false&useUnknownInCatchVariables=true#code/C4JwngBA3gsAUBCB6JEB0H4F8IGMCGwuAFhABQCmIIAlNPIihAOoUTH4BubwA9hNxABLAGaQqICEIDOEfADsGyVBN6SARhRFq2AV2lD5AcynA5s3vIpolo8hKnzpwBbgq8REAKLU1dWAiIeJbSvAA21mG8RpTUaAC2FNLS+EYUNADcSljY8PAiFETEZADkJTRoBEVksSB+EAC8AHz0gUzEVGyqkjIQHhDAYAAObApg2DRAA

DanielRosenwasser · 2021-11-05T23:15:16Z

Should the flag useUnknownInCatchVariables also affect the return type of Promise.prototype.catch?

@guilhermesimoes #45602 proposes that idea.

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Oct 9, 2020

DanielRosenwasser changed the title ~~'unknown' in catch variables~~ --useUnknownInCatchVariables Oct 9, 2020

DanielRosenwasser changed the title ~~--useUnknownInCatchVariables~~ Add flag to change 'catch' variable default to 'unknown' Oct 9, 2020

DanielRosenwasser force-pushed the unknownInCatchVariables branch from 87b36c9 to bbb3bfb Compare October 9, 2020 21:08

DanielRosenwasser marked this pull request as ready for review October 9, 2020 21:10

sandersn added the Experiment A fork with an experimental idea which might not make it into master label Oct 20, 2020

DanielRosenwasser force-pushed the unknownInCatchVariables branch from bbb3bfb to cccf22a Compare December 2, 2020 21:19

This was referenced Dec 4, 2020

Design Meeting Notes, 12/4/2020 #41824

Closed

Design Meeting Notes, 12/9/2020 #41907

Closed

DanielRosenwasser closed this Feb 9, 2021

DanielRosenwasser reopened this Feb 9, 2021

DanielRosenwasser and others added 6 commits May 5, 2021 21:27

Add test case for 'useUnknownInCatchVariables'.

ac4490c

Add new 'useUnknownInCatchVariables' flag.

07a9e49

Accepted baselines.

4f0baa0

Add test for catch variable explicitly typed as 'any'.

cc6e761

Accepted baselines.

cd08b62

Move option under 'strict'.

f529457

DanielRosenwasser force-pushed the unknownInCatchVariables branch from 7c01840 to f529457 Compare May 5, 2021 21:36

Accepted baselines.

a32013b

DanielRosenwasser removed the Experiment A fork with an experimental idea which might not make it into master label May 5, 2021

typescript-bot added For Milestone Bug PRs that fix a bug with a specific milestone and removed For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels May 14, 2021

DanielRosenwasser requested a review from ahejlsberg May 14, 2021 19:11

sandersn requested changes May 18, 2021

View reviewed changes

'useUnknownInCatchVariables' is strict in command line help.

0ea20ff

DanielRosenwasser requested a review from sandersn June 1, 2021 21:45

sandersn approved these changes Jun 2, 2021

View reviewed changes

Merge remote-tracking branch 'origin/main' into unknownInCatchVariables

49e652d

DanielRosenwasser merged commit 9906092 into main Jun 3, 2021

DanielRosenwasser deleted the unknownInCatchVariables branch June 3, 2021 20:13

DanielRosenwasser added the Breaking Change Would introduce errors in existing code label Jun 3, 2021

mkubilayk mentioned this pull request Jul 20, 2021

Bloomberg feedback on TypeScript 4.4 Beta #45117

Closed

Jack-Works mentioned this pull request Aug 2, 2021

chore: improve eslint DimensionDev/Maskbook#3835

Merged

rekmarks mentioned this pull request Aug 28, 2021

Fix no-throw-literal config for TypeScript MetaMask/eslint-config#201

Merged

kr8n3r mentioned this pull request Aug 31, 2021

Upgrade typescript and fix unknown ypes alphagov/paas-admin#1787

Merged

sainthkh mentioned this pull request Nov 16, 2021

chore: Update TypeScript to 4.4.4 cypress-io/cypress#18930

Merged

This was referenced Dec 6, 2021

docs(eslint-plugin): Mention useUnknownInCatchVariables in no-implicit-any-catch typescript-eslint/typescript-eslint#4252

Merged

useUnknownInCatchVariables does not apply to Promise#catch() #47033

Closed

wbt mentioned this pull request Dec 17, 2021

Error in catch clause should be unknown #26174

Closed

4 tasks

samwgoldman mentioned this pull request Mar 9, 2022

catch clause annotations tc39/proposal-type-annotations#47

Open

molisani mentioned this pull request Jul 11, 2022

Infer instance type arguments as constraint #49863

Closed

ndaemy mentioned this pull request May 8, 2024

[Refactor]Complete mju-likelion/custard-pudding#110

Merged

Add flag to change catch variables' default types to unknown #41013

Add flag to change catch variables' default types to unknown #41013

Uh oh!

Conversation

DanielRosenwasser commented Oct 9, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Dec 2, 2020

Uh oh!

johnnyreilly commented Feb 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented May 5, 2021

Uh oh!

typescript-bot commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented May 5, 2021

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sandersn May 18, 2021

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser May 24, 2021

Choose a reason for hiding this comment

Uh oh!

gvanrossum commented May 18, 2021

Uh oh!

DanielRosenwasser commented May 19, 2021

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

pvinis commented Sep 23, 2021

Uh oh!

guilhermesimoes commented Nov 5, 2021

Uh oh!

DanielRosenwasser commented Nov 5, 2021

Uh oh!

Uh oh!

Add flag to change `catch` variables' default types to `unknown` #41013

Add flag to change `catch` variables' default types to `unknown` #41013

DanielRosenwasser commented Oct 9, 2020 •

edited

Loading

johnnyreilly commented Feb 10, 2021 •

edited

Loading

typescript-bot commented May 5, 2021 •

edited

Loading

typescript-bot commented May 5, 2021 •

edited

Loading

typescript-bot commented May 5, 2021 •

edited

Loading

typescript-bot commented May 5, 2021 •

edited

Loading

typescript-bot commented May 5, 2021 •

edited

Loading

typescript-bot commented May 5, 2021 •

edited

Loading