Skip to content

Fix duplicate visit of param tag comments #44443

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jun 4, 2021

It was a misplaced parenthesis.

Fixes #44422

@DanielRosenwasser
Copy link
Member

@typescript-bot cherry-pick this to release-4.3

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 4, 2021

Heya @DanielRosenwasser, I've started to run the task to cherry-pick this into release-4.3 on this PR at d3c1539. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @DanielRosenwasser, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.3 manually.

@sandersn sandersn merged commit 8e1bf08 into main Jun 4, 2021
@sandersn sandersn deleted the fix-duplicate-visit-param-tag-comment branch June 4, 2021 19:54
DanielRosenwasser pushed a commit that referenced this pull request Jun 4, 2021
DanielRosenwasser added a commit that referenced this pull request Jun 4, 2021
Fixes #44422

Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
@sandersn sandersn mentioned this pull request Jun 17, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ts.Node.getChildren() returns duplicate copies of the same AST nodes in TS 4.3
3 participants