Skip to content

Use awaited type for await #45701

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Use awaited type for await #45701

wants to merge 2 commits into from

Conversation

rbuckton
Copy link
Member

@rbuckton rbuckton commented Sep 3, 2021

This is a follow-up to #45350 that investigates having await result in an Awaited<T> of the expression.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 3, 2021
@rbuckton
Copy link
Member Author

rbuckton commented Sep 3, 2021

@typescript-bot perf test
@typescript-bot run dt
@typescript-bot test this
@typescript-bot user test this inline

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 3, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the perf test suite on this PR at 5bdae61. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 3, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the inline community code test suite on this PR at 5bdae61. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 3, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the parallelized Definitely Typed test suite on this PR at 5bdae61. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Sep 3, 2021 •
edited
Loading

Heya @rbuckton, I've started to run the extended test suite on this PR at 5bdae61. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

@rbuckton
Great news! no new errors were found between main..refs/pull/45701/merge

@typescript-bot
Copy link
Collaborator

@rbuckton
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..45701

Metric main 45701 Delta Best Worst
Angular - node (v10.16.3, x64)
Memory used 351,573k (± 0.01%) 351,626k (± 0.02%) +53k (+ 0.02%) 351,476k 351,726k
Parse Time 1.91s (± 0.36%) 1.90s (± 0.26%) -0.01s (- 0.47%) 1.88s 1.90s
Bind Time 0.86s (± 1.04%) 0.85s (± 0.52%) -0.00s (- 0.47%) 0.84s 0.86s
Check Time 5.38s (± 0.38%) 5.42s (± 0.38%) +0.04s (+ 0.69%) 5.37s 5.46s
Emit Time 5.83s (± 0.67%) 5.83s (± 0.76%) +0.00s (+ 0.03%) 5.77s 5.99s
Total Time 13.97s (± 0.31%) 14.00s (± 0.32%) +0.03s (+ 0.20%) 13.89s 14.13s
Compiler-Unions - node (v10.16.3, x64)
Memory used 203,477k (± 0.03%) 203,494k (± 0.04%) +17k (+ 0.01%) 203,332k 203,680k
Parse Time 0.78s (± 0.83%) 0.78s (± 0.76%) +0.00s (+ 0.26%) 0.77s 0.80s
Bind Time 0.52s (± 0.69%) 0.52s (± 1.30%) +0.00s (+ 0.00%) 0.51s 0.54s
Check Time 7.84s (± 0.59%) 7.82s (± 0.37%) -0.02s (- 0.28%) 7.78s 7.90s
Emit Time 2.43s (± 0.36%) 2.44s (± 1.05%) +0.01s (+ 0.58%) 2.39s 2.50s
Total Time 11.58s (± 0.41%) 11.57s (± 0.39%) -0.00s (- 0.04%) 11.49s 11.68s
Monaco - node (v10.16.3, x64)
Memory used 340,593k (± 0.02%) 340,583k (± 0.02%) -9k (- 0.00%) 340,419k 340,786k
Parse Time 1.45s (± 0.76%) 1.45s (± 0.76%) -0.00s (- 0.21%) 1.41s 1.47s
Bind Time 0.75s (± 0.97%) 0.75s (± 1.19%) -0.00s (- 0.27%) 0.73s 0.77s
Check Time 5.44s (± 0.72%) 5.37s (± 0.52%) -0.06s (- 1.18%) 5.31s 5.42s
Emit Time 3.16s (± 0.97%) 3.16s (± 0.62%) +0.00s (+ 0.09%) 3.12s 3.21s
Total Time 10.79s (± 0.55%) 10.72s (± 0.27%) -0.07s (- 0.61%) 10.67s 10.81s
TFS - node (v10.16.3, x64)
Memory used 304,003k (± 0.02%) 304,034k (± 0.02%) +31k (+ 0.01%) 303,918k 304,191k
Parse Time 1.19s (± 0.47%) 1.18s (± 0.38%) -0.01s (- 0.84%) 1.17s 1.19s
Bind Time 0.72s (± 0.95%) 0.71s (± 0.91%) -0.00s (- 0.56%) 0.69s 0.72s
Check Time 4.94s (± 0.59%) 4.91s (± 0.51%) -0.03s (- 0.61%) 4.86s 4.97s
Emit Time 3.36s (± 1.93%) 3.30s (± 1.03%) -0.05s (- 1.64%) 3.20s 3.38s
Total Time 10.21s (± 0.86%) 10.11s (± 0.47%) -0.10s (- 0.97%) 9.98s 10.20s
material-ui - node (v10.16.3, x64)
Memory used 469,878k (± 0.01%) 469,897k (± 0.01%) +18k (+ 0.00%) 469,701k 470,041k
Parse Time 1.73s (± 0.59%) 1.73s (± 0.37%) -0.00s (- 0.06%) 1.72s 1.75s
Bind Time 0.67s (± 0.83%) 0.67s (± 1.03%) -0.00s (- 0.45%) 0.65s 0.68s
Check Time 14.17s (± 0.36%) 14.17s (± 0.35%) -0.00s (- 0.01%) 14.09s 14.31s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 16.57s (± 0.33%) 16.56s (± 0.33%) -0.01s (- 0.04%) 16.50s 16.73s
Angular - node (v12.1.0, x64)
Memory used 329,518k (± 0.03%) 329,644k (± 0.02%) +126k (+ 0.04%) 329,487k 329,834k
Parse Time 1.88s (± 0.61%) 1.88s (± 0.72%) +0.00s (+ 0.05%) 1.85s 1.92s
Bind Time 0.84s (± 0.59%) 0.84s (± 0.73%) +0.01s (+ 0.60%) 0.83s 0.85s
Check Time 5.23s (± 0.54%) 5.25s (± 0.30%) +0.02s (+ 0.36%) 5.21s 5.28s
Emit Time 6.07s (± 0.98%) 6.07s (± 0.53%) -0.00s (- 0.02%) 6.01s 6.14s
Total Time 14.02s (± 0.39%) 14.04s (± 0.29%) +0.02s (+ 0.16%) 13.98s 14.17s
Compiler-Unions - node (v12.1.0, x64)
Memory used 191,008k (± 0.09%) 190,848k (± 0.14%) -160k (- 0.08%) 190,112k 191,200k
Parse Time 0.78s (± 0.64%) 0.78s (± 0.90%) +0.01s (+ 0.77%) 0.77s 0.80s
Bind Time 0.53s (± 0.76%) 0.52s (± 0.91%) -0.01s (- 1.13%) 0.51s 0.53s
Check Time 7.36s (± 0.53%) 7.35s (± 0.48%) -0.01s (- 0.10%) 7.29s 7.44s
Emit Time 2.45s (± 0.92%) 2.45s (± 1.01%) +0.00s (+ 0.12%) 2.40s 2.51s
Total Time 11.12s (± 0.49%) 11.11s (± 0.42%) -0.01s (- 0.09%) 11.02s 11.22s
Monaco - node (v12.1.0, x64)
Memory used 323,757k (± 0.02%) 323,840k (± 0.03%) +83k (+ 0.03%) 323,587k 323,996k
Parse Time 1.43s (± 0.56%) 1.42s (± 0.51%) -0.01s (- 0.70%) 1.41s 1.44s
Bind Time 0.72s (± 0.68%) 0.73s (± 0.68%) +0.00s (+ 0.28%) 0.72s 0.74s
Check Time 5.29s (± 0.54%) 5.25s (± 0.43%) -0.03s (- 0.64%) 5.21s 5.31s
Emit Time 3.20s (± 0.56%) 3.19s (± 0.77%) -0.01s (- 0.34%) 3.14s 3.24s
Total Time 10.65s (± 0.45%) 10.59s (± 0.26%) -0.05s (- 0.51%) 10.55s 10.68s
TFS - node (v12.1.0, x64)
Memory used 288,767k (± 0.01%) 288,732k (± 0.02%) -35k (- 0.01%) 288,588k 288,824k
Parse Time 1.21s (± 0.68%) 1.21s (± 0.74%) -0.00s (- 0.17%) 1.18s 1.22s
Bind Time 0.70s (± 0.80%) 0.70s (± 1.00%) +0.00s (+ 0.43%) 0.69s 0.72s
Check Time 4.85s (± 0.42%) 4.83s (± 0.36%) -0.02s (- 0.33%) 4.78s 4.87s
Emit Time 3.36s (± 0.70%) 3.40s (± 0.78%) +0.04s (+ 1.07%) 3.34s 3.47s
Total Time 10.11s (± 0.41%) 10.14s (± 0.33%) +0.03s (+ 0.27%) 10.08s 10.24s
material-ui - node (v12.1.0, x64)
Memory used 448,684k (± 0.02%) 448,475k (± 0.08%) -208k (- 0.05%) 447,499k 448,771k
Parse Time 1.72s (± 0.51%) 1.72s (± 0.45%) +0.00s (+ 0.06%) 1.70s 1.73s
Bind Time 0.65s (± 1.08%) 0.65s (± 0.46%) -0.00s (- 0.15%) 0.64s 0.65s
Check Time 12.83s (± 0.45%) 12.79s (± 0.90%) -0.04s (- 0.30%) 12.61s 13.10s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.20s (± 0.39%) 15.16s (± 0.79%) -0.04s (- 0.27%) 14.95s 15.48s
Angular - node (v14.15.1, x64)
Memory used 328,115k (± 0.01%) 328,064k (± 0.05%) -51k (- 0.02%) 327,450k 328,159k
Parse Time 1.91s (± 0.49%) 1.89s (± 0.56%) -0.02s (- 0.99%) 1.88s 1.92s
Bind Time 0.88s (± 0.70%) 0.87s (± 0.54%) -0.01s (- 0.91%) 0.87s 0.89s
Check Time 5.28s (± 0.35%) 5.28s (± 0.47%) -0.00s (- 0.08%) 5.23s 5.34s
Emit Time 6.19s (± 0.96%) 6.17s (± 0.59%) -0.02s (- 0.40%) 6.07s 6.23s
Total Time 14.27s (± 0.49%) 14.21s (± 0.34%) -0.06s (- 0.39%) 14.05s 14.29s
Compiler-Unions - node (v14.15.1, x64)
Memory used 191,412k (± 0.68%) 191,529k (± 0.61%) +116k (+ 0.06%) 189,600k 192,855k
Parse Time 0.81s (± 0.69%) 0.80s (± 0.85%) -0.00s (- 0.50%) 0.79s 0.82s
Bind Time 0.56s (± 0.89%) 0.56s (± 0.65%) +0.00s (+ 0.00%) 0.55s 0.56s
Check Time 7.54s (± 0.56%) 7.49s (± 0.30%) -0.05s (- 0.64%) 7.43s 7.54s
Emit Time 2.48s (± 0.84%) 2.45s (± 0.84%) -0.03s (- 1.21%) 2.40s 2.50s
Total Time 11.38s (± 0.54%) 11.30s (± 0.31%) -0.08s (- 0.69%) 11.22s 11.39s
Monaco - node (v14.15.1, x64)
Memory used 322,545k (± 0.01%) 322,541k (± 0.00%) -4k (- 0.00%) 322,521k 322,553k
Parse Time 1.48s (± 0.74%) 1.48s (± 0.47%) -0.00s (- 0.07%) 1.47s 1.50s
Bind Time 0.76s (± 0.48%) 0.75s (± 0.77%) -0.01s (- 0.79%) 0.74s 0.76s
Check Time 5.22s (± 0.43%) 5.21s (± 0.55%) -0.01s (- 0.11%) 5.15s 5.29s
Emit Time 3.22s (± 0.76%) 3.21s (± 0.86%) -0.01s (- 0.22%) 3.16s 3.29s
Total Time 10.67s (± 0.36%) 10.65s (± 0.45%) -0.02s (- 0.22%) 10.54s 10.74s
TFS - node (v14.15.1, x64)
Memory used 287,682k (± 0.01%) 287,698k (± 0.00%) +17k (+ 0.01%) 287,670k 287,724k
Parse Time 1.25s (± 1.31%) 1.24s (± 1.75%) -0.00s (- 0.24%) 1.19s 1.28s
Bind Time 0.74s (± 3.03%) 0.74s (± 4.16%) +0.00s (+ 0.54%) 0.71s 0.82s
Check Time 4.86s (± 0.45%) 4.84s (± 0.54%) -0.02s (- 0.35%) 4.80s 4.92s
Emit Time 3.46s (± 0.95%) 3.44s (± 0.67%) -0.02s (- 0.64%) 3.38s 3.48s
Total Time 10.30s (± 0.40%) 10.26s (± 0.29%) -0.04s (- 0.37%) 10.18s 10.32s
material-ui - node (v14.15.1, x64)
Memory used 447,001k (± 0.00%) 447,049k (± 0.01%) +48k (+ 0.01%) 447,011k 447,105k
Parse Time 1.76s (± 0.40%) 1.76s (± 0.53%) +0.00s (+ 0.06%) 1.74s 1.78s
Bind Time 0.70s (± 0.68%) 0.69s (± 0.58%) -0.01s (- 0.86%) 0.68s 0.70s
Check Time 12.95s (± 0.58%) 12.92s (± 0.60%) -0.04s (- 0.30%) 12.75s 13.07s
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) 0.00s ( NaN%) 0.00s 0.00s
Total Time 15.41s (± 0.48%) 15.37s (± 0.53%) -0.05s (- 0.29%) 15.19s 15.51s

System
Machine Namets-ci-ubuntu
Platformlinux 4.4.0-210-generic
Architecturex64
Available Memory16 GB
Available Memory9 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v10.16.3, x64)
  • node (v12.1.0, x64)
  • node (v14.15.1, x64)
Scenarios
  • Angular - node (v10.16.3, x64)
  • Angular - node (v12.1.0, x64)
  • Angular - node (v14.15.1, x64)
  • Compiler-Unions - node (v10.16.3, x64)
  • Compiler-Unions - node (v12.1.0, x64)
  • Compiler-Unions - node (v14.15.1, x64)
  • Monaco - node (v10.16.3, x64)
  • Monaco - node (v12.1.0, x64)
  • Monaco - node (v14.15.1, x64)
  • TFS - node (v10.16.3, x64)
  • TFS - node (v12.1.0, x64)
  • TFS - node (v14.15.1, x64)
  • material-ui - node (v10.16.3, x64)
  • material-ui - node (v12.1.0, x64)
  • material-ui - node (v14.15.1, x64)
Benchmark Name Iterations
Current 45701 10
Baseline main 10

Developer Information:

Download Benchmark

@rbuckton
Copy link
Member Author

rbuckton commented Sep 3, 2021

Well, it looks like this had no noticeable impact on RWC and user tests, so maybe this isn't as breaking as I first assumed. I may merge this into the main PR.

@rbuckton rbuckton mentioned this pull request Sep 3, 2021
Merged
@rbuckton
Copy link
Member Author

rbuckton commented Sep 6, 2021

Merged into #45350

@rbuckton rbuckton closed this Sep 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

@rbuckton rbuckton

Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbuckton @typescript-bot