Skip to content

Fixed string literal completions for partially-typed strings when overload could get matched #48811

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

Andarist
Copy link
Contributor

Fixes #47227

This expands on the logic implemented in #48410

cc @andrewbranch

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Apr 22, 2022
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh awesome, great catch, thank you!

@andrewbranch andrewbranch merged commit af30c79 into microsoft:main Apr 22, 2022
@Andarist Andarist deleted the fix/47227 branch June 20, 2022 22:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Completions for string literal type parameter don't work if it's constraint includes an empty string
3 participants