-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Remove code related to prepend and fix baselines #57472
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
sheetalkamat
commented
Feb 21, 2024
- Removes all the APIs and call related prepend and corresponding tests
- Fixed the tests that didnt depend on prepend
- Also fixed issue with tsserver not baselining the version as FakeMajor.FakeMinor when the callbacks were baselined by passing around the logs
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
Package size reportOverall package size
Files
|
I feel a bit mixed - it's a little hard to read it casually (thanks GitHub), but what I want to know is:
If the language service stops working, it means we'll be unable to browse the code of TypeScript 4.9 and earlier with TypeScript 5.5+. |
IIRC |
@jakebailey said it correctly.. this affects emit and it shouldnt impact the LS at all. |
@@ -813,6 +813,9 @@ const commandOptionsWithoutBuild: CommandLineOption[] = [ | |||
{ | |||
name: "verbatimModuleSyntax", | |||
type: "boolean", | |||
affectsEmit: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this belong in its own PR? Looks unrelated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was related to baseline i fixed so added it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_FYI'ing: this broke wessberg/rollup-plugin-ts#227 |
Noted. The removed API has been marked deprecated since 5.0 per #51909 |
@RyanCavanaugh Thank you! Is there a suggested alternative API to |
The only (intended) legal thing to do with |