Skip to content

Add check for unknown type #61810

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 3 commits into from
Closed

Add check for unknown type #61810

wants to merge 3 commits into from

Conversation

CamBoyd
Copy link

@CamBoyd CamBoyd commented Jun 4, 2025

Fixes #29707

Added check for unknown type to fix issue when declaring a class constructor.

@github-project-automation github-project-automation bot moved this to Not started in PR Backlog Jun 4, 2025
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 4, 2025
Comment on lines +40619 to +40621
if (isBoolean(left) || isBoolean(right)) {
return true;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems unrelated?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is unrelated, it is from my previous PR. I fetched from Main and pulled before making this commit, but I guess it was still in there. Oops, my bad. I didn't want to make this PR, I only did it for a school assignment. I was hoping this would be ignored like my last PR. I apologize for wasting your time.

Copy link
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked too closely at this, but this definitely must have testcases

@github-project-automation github-project-automation bot moved this from Not started to Waiting on author in PR Backlog Jun 9, 2025
@CamBoyd CamBoyd closed this Jun 18, 2025
@github-project-automation github-project-automation bot moved this from Waiting on author to Done in PR Backlog Jun 18, 2025
@CamBoyd
Copy link
Author

CamBoyd commented Jun 18, 2025

I only made this PR for a school assignment. It has been graded, so I am closing this.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TS is overly picky when declaring a class constructor type
4 participants