Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update DistributionInfo.json #12451

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

sbradnick
Copy link
Contributor

Adding "openSUSE" section to "ModenDistributions".

Adding "openSUSE" section to "ModenDistributions".
@benhillis benhillis requested a review from OneBlue January 14, 2025 21:47
@OneBlue
Copy link
Collaborator

OneBlue commented Jan 14, 2025

Thank you @sbradnick, this is looking good.

This is just missing a default entry for openSUSE (Default=True). That's for wsl to know which version to install if the user runs:

wsl --install opensuse

Setting TW as default.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution to WSL.
No fatal errors have been found.
The following suggestions have been found in this pull request:

@sbradnick
Copy link
Contributor Author

Thank you @sbradnick, this is looking good.

This is just missing a default entry for openSUSE (Default=True). That's for wsl to know which version to install if the user runs:

wsl --install opensuse

I've set TW as the default.

@OneBlue
Copy link
Collaborator

OneBlue commented Jan 14, 2025

Thanks @sbradnick.

Sorry I just noticed this: Could you use gz compression instead of xz ?
The reason for that is that wsl1 unfortunately doesn't support xz

Also could you change the distribution url's to have the .wsl extension ?
That way if users manually downloaded the distribution, they could just install them via double clicking.

@sbradnick
Copy link
Contributor Author

Sorry I just noticed this: Could you use gz compression instead of xz ?

kiwi-ng defaults to xz and that doesn't appear to be a configurable option --> https://osinside.github.io/kiwi/image_description/elements.html

So at this point, I'd say no I can't.

It also isn't an option to build a .tar.xz image but as a last step, rename it to .wsl. But that's such a trivial action for the end user ...

The reason for that is that wsl1 unfortunately doesn't support xz

I don't believe we're overly concerned with support for wsl1 on our side.

Also could you change the distribution url's to have the .wsl extension ?
That way if users manually downloaded the distribution, they could just install them via double clicking.

I can going forward (don't really want to cut a new GH release just for that); but if that's the expectation, I wasn't aware it applied here since --web-download isn't a mouse action. I'd agree it's convenient and 'neat', but so trivial it should be optional, not required.

@OneBlue
Copy link
Collaborator

OneBlue commented Jan 15, 2025

I don't believe we're overly concerned with support for wsl1 on our side.

Sounds good, it's your call.

I can going forward (don't really want to cut a new GH release just for that); but if that's the expectation, I wasn't aware it applied here since --web-download isn't a mouse action. I'd agree it's convenient and 'neat', but so trivial it should be optional, not required.

It is optional indeed. I'm ok with merging this pull request as-is and changing this in the next release.

Copy link
Member

@benhillis benhillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're discussing internally how to handle xz support. Holding off on merging this until we have decided on a stance here.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants