Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Develop #24

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Develop #24

wants to merge 2 commits into from

Conversation

venkatkongara
Copy link
Contributor

@venkatkongara venkatkongara commented Apr 11, 2017

This change is Reviewable

@andrejo-msft andrejo-msft mentioned this pull request Apr 11, 2017
__weak typeof(self) weakSelf = self;
switch (indexPath.row) {
case 0: {
dispatch_async(dispatch_get_global_queue(DISPATCH_QUEUE_PRIORITY_BACKGROUND, 0), ^{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm hitting an exception here in my work environment. Are you seeing the same thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrejo-msft I did not see the exception on my machine. I was using Feb 28th pre release of WINOBJC on visual studio 2015. It looks like there might be a problem with the regression of WINOBJC. please let me know your WINBJC version

#import <UIKit/UIKit.h>
#import "BaseViewController.h"

@interface NSDataDeserializeViewController : BaseViewController
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to NSArrayDeserialize...


@end

@implementation NSDataDeserializeViewController
Copy link
Member

@andrejo-msft andrejo-msft Apr 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exception on this view controller as well. Is this appearing in iOS? I'd assume not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not hitting the exception on windows and Ios @andrejo-msft

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I will try it in my other environment.

@andrejo-msft
Copy link
Member

  • (void)clearCache

clearCache appears to be the culprit for the exceptions mentioned in other places. Running clear cache without any data appears to work fine, but there's a problem with clearCache otherwise.


Refers to: ThirdParty/Middleware-JsonKit/JSONKit/JSONKit/JSONKit.m:2146 in b7c0669. [](commit_id = b7c0669, deletion_comment = False)

@andrejo-msft
Copy link
Member

There appears to be a regression surrounding clearCache (mentioned in other comments.)

@andrejo-msft
Copy link
Member

🕐

@andrejo-msft
Copy link
Member

andrejo-msft commented Apr 12, 2017 via email

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants