Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix length bug on row aria labels for tables #25789

Merged
merged 9 commits into from
Jul 26, 2024
Merged

Conversation

laurennat
Copy link
Contributor

No description provided.

@laurennat laurennat merged commit 34abe6e into main Jul 26, 2024
6 of 8 checks passed
@laurennat laurennat deleted the laurennat/linuxbugs branch July 26, 2024 18:47
@coveralls
Copy link

coveralls commented Jul 26, 2024

Pull Request Test Coverage Report for Build 10116154908

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 41.725%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/workbench/api/common/extHostModelView.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 1 45.22%
Totals Coverage Status
Change from base Build 10103174561: -0.002%
Covered Lines: 30728
Relevant Lines: 68915

💛 - Coveralls

kburtram added a commit that referenced this pull request Jul 29, 2024
)

* vBumping post release branch split (#25747)

* Update to latest STS (#25750)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/import (#25745)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update STS to 5.0.20240718.1 (#25754)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/datavirtualization (#25751)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /extensions/data-workspace (#25756)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /extensions/dacpac (#25758)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fixed column header screen reader bug (#25768)

* Revert "fixed column header screen reader bug (#25768)" (#25769)

This reverts commit ae652f7.

* Fixed column screen reader bug and ensure tests work (#25770)

* fixed column header screen reader bug

* fixed case of undefined aria label

* Bump braces from 3.0.2 to 3.0.3 in /extensions/cms (#25763)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump openssl from 0.10.60 to 0.10.66 in /cli (#25764)

Bumps [openssl](https://github.com/sfackler/rust-openssl) from 0.10.60 to 0.10.66.
- [Release notes](https://github.com/sfackler/rust-openssl/releases)
- [Commits](sfackler/rust-openssl@openssl-v0.10.60...openssl-v0.10.66)

---
updated-dependencies:
- dependency-name: openssl
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update STS to 5.0.20240724.1 (#25774)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/azurecore (#25771)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump braces from 3.0.2 to 3.0.3 in /extensions/azcli (#25775)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Adding Fabric SQL Mirrored support to the SQL Projects (#25772)

* Adding Sql fabric platform support to sqlProj extension and vBump BuildSdk version to 0.2.0-preview

* updating the display targetPlat text and updaing the buildSDK version in template

* Update extensions/sql-database-projects/src/sqldbproj.d.ts

Update text

Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>

* Adding fabric engine edition

* adding missing engine edition to sqlhostType

---------

Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>

* sqlProj vbump (#25781)

* Fixed text focus/ page item focus issue on forms and wizards (#25782)

* fixed column header screen reader bug

* fixed case of undefined aria label

* added text focus, and added form item focus

* Fixed screen reader not announcing table row number (#25784)

* fixed column header screen reader bug

* fixed case of undefined aria label

* added text focus, and added form item focus

* fixed row results not getting announced

* added punctuation

* Fix length bug on row aria labels for tables (#25789)

* fixed column header screen reader bug

* fixed case of undefined aria label

* added text focus, and added form item focus

* fixed row results not getting announced

* added punctuation

* Fix length check bug

* remove extra row aria call

* trying to fix nls pipeline bug (#25790)

* Bump braces from 3.0.2 to 3.0.3 in /extensions/arc (#25776)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Revert "vBumping post release branch split (#25747)"

This reverts commit 5ae6f59.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: erpett <97994807+erpett@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: laurennat <laurennathan@vt.edu>
Co-authored-by: Sai Avishkar Sreerama <74571829+ssreerama@users.noreply.github.com>
Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants