ResumeDialog is not called after resumption with adaptivedialog (#5426) #5427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add unit test. * Added logic to ensure "turn.interrupted" is set before an interrupted action is continued. * Update SkillConversationFactory to return a different ID every time CreateSkillConversationIdAsync is called. Added check to InputDialog to ignore incoming activity if this is a reprompt. Fixed broken tests. Co-authored-by: Steven Ickman <stevenic@microsoft.com> Co-authored-by: Gabo Gilabert <ggilaber@microsoft.com>
gabog
requested review from
chrimc62,
tomlm,
Stevenic,
peterinnesmsft,
lauren-mills and
dmvtech
mrivera-ms
approved these changes
Apr 6, 2021
Open
14 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry for #5426 into 4.13 branch