Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Updates for CallerId handling #455

Closed
tomlm opened this issue Apr 17, 2020 · 0 comments · Fixed by #454
Closed

Updates for CallerId handling #455

tomlm opened this issue Apr 17, 2020 · 0 comments · Fixed by #454
Assignees
@tracyboehrer
Milestone
R9

Comments

@tomlm
Copy link
Contributor

tomlm commented Apr 17, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3753

Updated callerId assignment to be taken from claims after auth rather than from the activity.
Updated related tests.
Applied temporary fix for the new callerId log for DialogManager (final fix will be done after refactoring to match DialogExtensions.RunAsync logic).

Changed projects

  • Microsoft.Bot.Builder.Dialogs.Adaptive
  • Microsoft.Bot.Builder
  • Microsoft.Bot.Schema
  • integration
  • Microsoft.Bot.Builder.Dialogs.Tests
  • Microsoft.Bot.Builder.Tests
@tracyboehrer tracyboehrer mentioned this issue Apr 17, 2020
Merged
@tracyboehrer tracyboehrer self-assigned this Apr 17, 2020
@tracyboehrer tracyboehrer changed the title [PORT] Updates for CallerId Updates for CallerId handling May 4, 2020
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@tracyboehrer tracyboehrer

Labels
None yet
Projects
None yet
Milestone
R9
Development

Successfully merging a pull request may close this issue.

CallerId is getting set on incoming Activity microsoft/botbuilder-java
3 participants
@tracyboehrer @tomlm @munozemilio