Updates for CallerId #3753
Merged
Updates for CallerId #3753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than from the activity. Updated related tests. Applied temporary fix for the new callerId log for DialogManager (final fix will be done after refactoring to match DialogExtensions.RunAsync logic).
gabog
requested review from
cleemullins,
johnataylor,
mrivera-ms and
tomlm
as code owners
|
Is there an issue for this fix? |
Added CallerIdConstants with the valid callerId values and updated hardcoded usages. Updated unit tests to test for new callerId permutations
8 tasks
dandriscoll
approved these changes
Apr 17, 2020
johnataylor
approved these changes
Apr 17, 2020
This was referenced Apr 17, 2020
gabog
added a commit
that referenced
this pull request
Apr 20, 2020
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated callerId assignment to be taken from claims after auth rather than from the activity.
Updated related tests.
Applied temporary fix for the new callerId log for DialogManager (final fix will be done after refactoring to match DialogExtensions.RunAsync logic).