Skip to content

[PORT] Updates for CallerId #964

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
tomlm opened this issue Apr 17, 2020 · 0 comments · Fixed by #958
Closed

[PORT] Updates for CallerId #964

tomlm opened this issue Apr 17, 2020 · 0 comments · Fixed by #958
Assignees
@tracyboehrer
Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 6th, 2020
Milestone
R9

Comments

@tomlm
Copy link
Contributor

tomlm commented Apr 17, 2020

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3753

Updated callerId assignment to be taken from claims after auth rather than from the activity.
Updated related tests.
Applied temporary fix for the new callerId log for DialogManager (final fix will be done after refactoring to match DialogExtensions.RunAsync logic).

Changed projects

  • Microsoft.Bot.Builder.Dialogs.Adaptive
  • Microsoft.Bot.Builder
  • Microsoft.Bot.Schema
  • integration
  • Microsoft.Bot.Builder.Dialogs.Tests
  • Microsoft.Bot.Builder.Tests
@tracyboehrer tracyboehrer added P0 Must Fix. Release-blocker R9 Release 9 - May 6th, 2020 labels Apr 17, 2020
@tracyboehrer tracyboehrer self-assigned this Apr 17, 2020
@tracyboehrer tracyboehrer mentioned this issue Apr 17, 2020
Merged
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@tracyboehrer tracyboehrer

Labels
P0 Must Fix. Release-blocker R9 Release 9 - May 6th, 2020
Projects
None yet
Milestone
R9
Development

Successfully merging a pull request may close this issue.

Updates for CallerId microsoft/botbuilder-python
3 participants
@tracyboehrer @tomlm @munozemilio