Skip to content

Update RustCli Parsing to process pkgId, and introduce manual override #1106

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
May 16, 2024

Conversation

FernandoRojo
Copy link
Contributor

Allows users to manually override rustCLI detector by setting an environment variable DisableRustCliScan=True

Updates cargo metadata output processing to adhere to changes introduced that make the output follow the PkgId Spec: https://doc.rust-lang.org/cargo/reference/pkgid-spec.html

Changes to the metadata output were introduced in 1.77: rust-lang/cargo#12914

@FernandoRojo FernandoRojo requested a review from a team as a code owner May 14, 2024 02:25
@FernandoRojo FernandoRojo requested a review from melotic May 14, 2024 02:25
Copy link

github-actions bot commented May 14, 2024

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 75.9%. Comparing base (a513de5) to head (e24a678).
Report is 7 commits behind head on main.

Files Patch % Lines
...mponentDetection.Detectors/rust/RustCliDetector.cs 89.2% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1106     +/-   ##
=======================================
+ Coverage   75.7%   75.9%   +0.2%     
=======================================
  Files        239     247      +8     
  Lines      10822   11089    +267     
  Branches    1086    1137     +51     
=======================================
+ Hits        8193    8419    +226     
- Misses      2317    2347     +30     
- Partials     312     323     +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cobya
Copy link
Contributor

cobya commented May 14, 2024

@FernandoRojo to verify, the new locations in snapshot verification are expected correct?

@cobya cobya added type:feature Feature (new functionality) detector:rust The Rust Cargo detector labels May 15, 2024
@cobya cobya merged commit 5894c27 into main May 16, 2024
23 of 26 checks passed
@cobya cobya deleted the ferojo/rustFallbackManual branch May 16, 2024 21:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
detector:rust The Rust Cargo detector type:feature Feature (new functionality)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants