Kegordo/makefile cleanup #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icy. Signed-off-by: Ken Gordon <Ken.Gordon@microsoft.com>
…ED= and ISSUER_DID overrides will work. Note though that the signing is by the (generated) private key and so setting the ISSUER_DID override will result in a badly formed fragment, as in the fragment case the issuer DID MUST match the cert chain. Signed-off-by: Ken Gordon <Ken.Gordon@microsoft.com>
Signed-off-by: Ken Gordon <Ken.Gordon@microsoft.com>
Change order so that the infra.rego.cose exists.
Remove references of `infra.rego.cose.base64` from Makefile and code. Add `AUTOPARSE_CHAIN` param to makefile, which will parse the pem certs automatically, otherwise test values will be set. Update tests expectations and parameters Signed-off-by: Maksim An <maksiman@microsoft.com>
anmaxvl
approved these changes
Oct 30, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft to check delta.