Search Parameter validation failure issues logged (#3341)

* logging actual issue search parameter was invalid * using SB to log all issues together * simplified code
microsoft · Jun 8, 2023 · 25b6caf · 25b6caf
1 parent 2c809e4
commit 25b6caf
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/Microsoft.Health.Fhir.Core/Features/Definition/SearchParameterDefinitionManager.cs b/src/Microsoft.Health.Fhir.Core/Features/Definition/SearchParameterDefinitionManager.cs
@@ -8,6 +8,7 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Linq;
+using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 using EnsureThat;
@@ -258,13 +259,15 @@ private async Task LoadSearchParamsFromDataStore(CancellationToken cancellationT
                                 _modelInfoProvider,
                                 _logger);
                         }
-                        catch (SearchParameterNotSupportedException ex)
+                        catch (FhirException ex)
                         {
-                            _logger.LogWarning(ex, "Error loading search parameter {Url} from data store.", searchParam.GetStringScalar("url"));
-                        }
-                        catch (InvalidDefinitionException ex)
-                        {
-                            _logger.LogWarning(ex, "Error loading search parameter {Url} from data store.", searchParam.GetStringScalar("url"));
+                            StringBuilder issueDetails = new StringBuilder();
+                            foreach (OperationOutcomeIssue issue in ex.Issues)
+                            {
+                                issueDetails.Append(issue.Diagnostics).Append("; ");
+                            }
+
+                            _logger.LogWarning(ex, "Error loading search parameter {Url} from data store. Issues: {Issues}", searchParam.GetStringScalar("url"), issueDetails.ToString());
                         }
                         catch (Exception ex)
                         {