Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Adds CosmosQueueClient #3140

Merged
merged 6 commits into from
Mar 10, 2023
Merged

Adds CosmosQueueClient #3140

merged 6 commits into from
Mar 10, 2023

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Feb 21, 2023 •
edited
Loading

Description

Adds CosmosQueueClient class. This PR is benign in that I doesn't change any behavior, it just adds this provider for Cosmos.

image

Next steps: After this Export in Cosmos and SQL can share more common code paths: personal/bkowitz/cosmos-queueclient...personal/bkowitz/cosmos-queueclient-export2

Testing

Refactors and uses existing QueueClientTests

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch

@brendankowitz brendankowitz force-pushed the personal/bkowitz/cosmos-queueclient branch 3 times, most recently from 967cff9 to a4f1e55 Compare February 21, 2023 06:44
@brendankowitz brendankowitz added this to the S109 milestone Feb 21, 2023
@brendankowitz brendankowitz added Enhancement Enhancement on existing functionality. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Feb 21, 2023
@brendankowitz brendankowitz force-pushed the personal/bkowitz/cosmos-queueclient branch from a4f1e55 to fc0b875 Compare February 21, 2023 16:59
@brendankowitz brendankowitz marked this pull request as ready for review February 21, 2023 22:28
@brendankowitz brendankowitz requested a review from a team as a code owner February 21, 2023 22:28
@brendankowitz brendankowitz changed the title [Draft] Adds CosmosQueueClient Adds CosmosQueueClient Feb 21, 2023
@brendankowitz brendankowitz force-pushed the personal/bkowitz/cosmos-queueclient branch 2 times, most recently from 716028f to 774a7ed Compare February 28, 2023 21:33
@brendankowitz brendankowitz force-pushed the personal/bkowitz/cosmos-queueclient branch from 774a7ed to df61a45 Compare March 6, 2023 17:29
@brendankowitz brendankowitz modified the milestones: S109, S110 Mar 6, 2023
@brendankowitz brendankowitz force-pushed the personal/bkowitz/cosmos-queueclient branch from df61a45 to acd1f3c Compare March 6, 2023 18:12
@brendankowitz brendankowitz merged commit f81918d into main Mar 10, 2023
@brendankowitz brendankowitz deleted the personal/bkowitz/cosmos-queueclient branch March 10, 2023 16:41
LTA-Thinking pushed a commit that referenced this pull request Mar 22, 2023
@brendankowitz @LTA-Thinking
Adds CosmosQueueClient (#3140)
5969853
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@feordin feordin feordin approved these changes

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Enhancement Enhancement on existing functionality.
Projects
None yet
Milestone
S110
Development

Successfully merging this pull request may close these issues.
2 participants
@brendankowitz @feordin