Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add check for Container Registry token on custom requests #3320

Merged
merged 7 commits into from
Jun 4, 2023

Conversation

ShaunDonn
Copy link
Contributor

@ShaunDonn ShaunDonn commented May 31, 2023

Description

Added interface called IContainerRegistryTokenVerifier with method CheckIfContainerRegistryAccessIsEnabled. In OSS, the base implementation of this method returns nothing, so it will not impact the current control flow. In PaaS, we will add an implementation of CheckIfContainerRegistryAccessIsEnabled which checks whether or not ExternalMI has been configured. If it has, the method will just return, if not, it will throw a 400-level error with a message specifying that External MI is not configured, which is required for custom requests.

Related issues

Addresses work item #103457

Testing

  • all unit and integration tests pass

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@ShaunDonn ShaunDonn added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Open source This change is only relevant to the OSS code or release. labels May 31, 2023
@ShaunDonn ShaunDonn added this to the S116 milestone May 31, 2023
@ShaunDonn ShaunDonn requested a review from ms-teli May 31, 2023 23:48
@ShaunDonn ShaunDonn requested a review from a team as a code owner May 31, 2023 23:48
@ShaunDonn ShaunDonn changed the title Added check for Container Registry token on custom convert requests Add check for Container Registry token on custom requests Jun 1, 2023
@PTaladay PTaladay merged commit e105f98 into main Jun 4, 2023
@PTaladay PTaladay deleted the personal/sdonnelly/external-mi-500-error-bug-fix branch June 4, 2023 22:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug. Open source This change is only relevant to the OSS code or release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants