HostingBackgroundService should wait for StorageInitialized #3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankowitz
added
Azure API for FHIR
brendankowitz
changed the title
LTA-Thinking
reviewed
Jun 6, 2023
LTA-Thinking
reviewed
Jun 6, 2023
| { | ||
| EnsureArg.IsNotNull(jobFactories, nameof(jobFactories)); | ||
|
|
||
| _jobFactoryLookup = new Dictionary<int, Func<IJob>>(); | ||
|
|
||
| foreach (Func<IJob> jobFunc in jobFactories) | ||
| { | ||
| var instance = jobFunc.Invoke(); | ||
| if (instance.GetType().GetCustomAttribute(typeof(JobTypeIdAttribute), false) is JobTypeIdAttribute jobTypeAttr) | ||
| try |
There was a problem hiding this comment.
Why wrap this in a try/catch here? This looks like it would allow the JobFactory to be created successfully without all of the job types successfully added. This should be caught during testing as the affected job type wouldn't run, but I don't see why we would want this to succeed if there are broken job types.
There was a problem hiding this comment.
What I found was, the Queues determine the job types that are needed, Job Types can be registered that aren't used. In this examples Import was in core and registered, but this isn't ever used by a Cosmos instance. Stands to reason that if it is registered is should function, I'll change this to a throw
brendankowitz
force-pushed
the
personal/bkowitz/jobhost-storagenotifications
branch
2 times, most recently
from
fc44b6c to
4cd2169
Compare
LTA-Thinking
previously approved these changes
Jun 7, 2023
brendankowitz
force-pushed
the
personal/bkowitz/jobhost-storagenotifications
branch
from
4cd2169 to
27bb0ce
Compare
LTA-Thinking
approved these changes
Jun 8, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HostingBackgroundService should wait for StorageInitializedNotification, jobs that require QueueClient (all) or any data access should respect this. This allows all job tasks to inherit this behavior.
@PTaladay, @LTA-Thinking
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)