Added Status and $Status operation to CapabilityStatement #3381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this exception Hl7.Fhir.ElementModel.StructuralTypeException: 'Type checking the data: Choice element 'value' is not suffixed with a type. (at CapabilityStatement.rest[0].resource[0].searchParam[0].extension[0].value[0])'
…stats for search param.
…n the capability statement.
PTaladay
added
Enhancement
abiisnn
reviewed
Jul 6, 2023
src/Microsoft.Health.Fhir.Core/Features/Conformance/CapabilityStatementBuilder.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Shared.Api/Controllers/OperationDefinitionController.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Data/OperationDefinition/search-parameter-status.json
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Shared.Core.UnitTests/Features/Conformance/ConformanceBuilderTests.cs
Show resolved
Hide resolved
fhibf
reviewed
Jul 10, 2023
| @@ -65,6 +65,8 @@ internal static class RouteNames | |||
|
|
|||
| internal const string PurgeHistoryDefinition = "PurgeHistoryDefinition"; | |||
|
|
|||
| internal const string SearchParameterStatusOperationDefinition = "SearchParameterStatusOperationDefinition"; | |||
There was a problem hiding this comment.
Low priority: You can replace the static string with nameof(SearchParameterStatusOperationDefinition).
There was a problem hiding this comment.
I can add that as a fix in another PR.
fhibf
approved these changes
Jul 10, 2023
Comment on lines
+671
to
+673
| var task = Task.Run(() => builder.PopulateDefaultResourceInteractions() | ||
| .SyncSearchParametersAsync(CancellationToken.None)); | ||
| task.Wait(); |
There was a problem hiding this comment.
Should we be using: https://learn.microsoft.com/en-us/dotnet/api/system.threading.tasks.task.runsynchronously?view=net-7.0 here?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated capability statement to display search parameter status in the documentation field. $status operation is also displayed only when feature flag is enabled.
I used the documentation field because the firely sdk doesn't allow extending on the search param component or any component that relates to the search parameter.
Related issues
Addresses [issue AB#10442].
Testing
Ran through running the metadata endpoint with the different configuration options.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)