Removed Status for Search Params in Capability Statement #3413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTaladay
added
Bug
…lder as it is no longer used after this reversion.
fhibf
reviewed
Jul 22, 2023
| @@ -184,13 +177,12 @@ public ICapabilityStatementBuilder AddGlobalSearchParameters() | |||
| return this; | |||
| } | |||
|
|
|||
| private async Task<ICapabilityStatementBuilder> SyncSearchParamsAsync(string resourceType, CancellationToken cancellationToken) | |||
| private ICapabilityStatementBuilder SyncSearchParamsAsync(string resourceType) | |||
There was a problem hiding this comment.
Low priority: we should rename this method. I had the impression it was async.
There was a problem hiding this comment.
I missed that. Without seach parameter status mamager they went back to synch calls.
fhibf
reviewed
Jul 22, 2023
| @@ -340,10 +330,8 @@ public ICapabilityStatementBuilder PopulateDefaultResourceInteractions() | |||
| return this; | |||
| } | |||
|
|
|||
| public async Task<ICapabilityStatementBuilder> SyncSearchParametersAsync(CancellationToken cancellationToken) | |||
| public ICapabilityStatementBuilder SyncSearchParametersAsync() | |||
There was a problem hiding this comment.
Low priority: This one should be renamed as well. The async suffix causes doubts.
fhibf
approved these changes
Jul 22, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change to use Documentation field to host search parameter status was redundant since it always is "Enabled". Removing this as it isn't needed.
Related issues
Addresses [issue AB#104442].
Testing
Ran Capability statement Unit Tests, and manually validated that the field no longer displays the status.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)