Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix reindex calls so that they correctly apply retry calls #3451

Merged
merged 3 commits into from
Aug 2, 2023
Merged

fix reindex calls so that they correctly apply retry calls #3451

merged 3 commits into from
Aug 2, 2023

Conversation

v-mserdar
Copy link
Contributor

@v-mserdar v-mserdar commented Aug 1, 2023 •
edited
Loading

Description

Remove the unused sqlconnectionwrapperfactory; apply the correct sql retry to the reindex functions

Related issues

Addresses [issue #].

Testing

Successfully ran reindex jobs locally.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@v-mserdar v-mserdar added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Aug 1, 2023
@v-mserdar v-mserdar added this to the S120 milestone Aug 1, 2023
@v-mserdar v-mserdar requested a review from a team as a code owner August 1, 2023 22:41
SergeyGaluzo
SergeyGaluzo approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@v-mserdar v-mserdar merged commit f5dc8d6 into main Aug 2, 2023
@v-mserdar v-mserdar deleted the personal/v-mserdar/sqlretry_update_reindex branch August 2, 2023 18:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@PTaladay PTaladay PTaladay approved these changes

@SergeyGaluzo SergeyGaluzo SergeyGaluzo approved these changes

Assignees
No one assigned
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Milestone
S120
Development

Successfully merging this pull request may close these issues.
3 participants
@v-mserdar @PTaladay @SergeyGaluzo