Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Updates analysis build task #3476

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Updates analysis build task #3476

merged 4 commits into from
Aug 21, 2023

Conversation

brendankowitz
Copy link
Member

@brendankowitz brendankowitz commented Aug 9, 2023 •
edited
Loading

Description

Adds any applicable missing tools from InternalChecks into: Analyze.yml

Testing

Build and build logs should indicate the tools have run successfully.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Skip

@brendankowitz brendankowitz force-pushed the personal/bkowitz/retire-internal-checks branch 2 times, most recently from 30f5bd6 to 5751b53 Compare August 9, 2023 18:11
@PTaladay PTaladay added this to the S121 milestone Aug 11, 2023
@brendankowitz brendankowitz force-pushed the personal/bkowitz/retire-internal-checks branch 2 times, most recently from 6c782dd to fa524f9 Compare August 14, 2023 18:09
@brendankowitz brendankowitz force-pushed the personal/bkowitz/retire-internal-checks branch from fa524f9 to 1fb471a Compare August 14, 2023 18:14
@PTaladay PTaladay added the Build label Aug 14, 2023
@brendankowitz brendankowitz force-pushed the personal/bkowitz/retire-internal-checks branch 4 times, most recently from b8182ee to f4abd37 Compare August 16, 2023 04:59
@brendankowitz brendankowitz marked this pull request as ready for review August 16, 2023 14:57
@brendankowitz brendankowitz requested a review from a team as a code owner August 16, 2023 14:57
@brendankowitz brendankowitz force-pushed the personal/bkowitz/retire-internal-checks branch from f4abd37 to 49e811c Compare August 16, 2023 15:17
LTA-Thinking
LTA-Thinking reviewed Aug 16, 2023
View reviewed changes
build/jobs/analyze.yml
targetFiles: 'f|*.json'
excludePassesFromLog: false
- task: TemplateAnalyzer@3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: missing line break between tasks.

LTA-Thinking
LTA-Thinking previously approved these changes Aug 16, 2023
View reviewed changes
@brendankowitz brendankowitz merged commit 2951f57 into main Aug 21, 2023
@brendankowitz brendankowitz deleted the personal/bkowitz/retire-internal-checks branch August 21, 2023 18:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@rbans96 rbans96 rbans96 approved these changes

@LTA-Thinking LTA-Thinking LTA-Thinking left review comments

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
S121
Development

Successfully merging this pull request may close these issues.
4 participants
@brendankowitz @LTA-Thinking @rbans96 @PTaladay