-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Export with history and soft deletes #3519
Export with history and soft deletes #3519
Conversation
Also cleaned up some left over comments from previous commit
@LTA-Thinking - ready for SQL implementation when you are ready. I have a couple open questions for you as well:
|
src/Microsoft.Health.Fhir.Core/Features/Operations/Export/ExportJobTask.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Operations/Export/Models/ExportJobRecord.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Search/SearchOptions.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/ExportDataValidationTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core.UnitTests/Features/Operations/Export/ExportJobTaskTests.cs
Outdated
Show resolved
Hide resolved
Can you also update the Operation Definition for export? |
I think adding it to the serializer is sufficient. I don't think a generic solution is needed right now. |
src/Microsoft.Health.Fhir.Core/Features/KnownQueryParameterNames.cs
Outdated
Show resolved
Hide resolved
...t.Health.Fhir.SqlServer/Features/Schema/Sql/Sprocs/GetResourcesByTypeAndSurrogateIdRange.sql
Outdated
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Export/ExportTestHelper.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Export/ExportDataTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.Health.Fhir.Shared.Tests.E2E/Rest/Export/ExportDataTests.cs
Outdated
Show resolved
Hide resolved
…om:microsoft/fhir-server into feature/export/include-history-soft-delete
src/Microsoft.Health.Fhir.Core/Features/Search/ResourceVersionType.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core/Features/Search/ResourceVersionType.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
_includeHistory
and_includeDeleted
) to Export operation._typeFilter
because there are no longer search parameters with history/soft deletes. Validation added to address this.IncludeHistory
andIncludeDeleted
. This is passed down to the data store during searches.true
.Testing
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)