Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[CMK & Health State] Health Check refactoring #3535

Merged
merged 8 commits into from
Sep 29, 2023
Merged

[CMK & Health State] Health Check refactoring #3535

merged 8 commits into from
Sep 29, 2023

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented Sep 23, 2023

Description

Health Check refactoring

Testing

Change Health Check logic to better handle CMK failures.
Start supporting "Degraded" status instead of raised HTTP500.

FHIR Team Checklist

@fhibf fhibf added Enhancement Enhancement on existing functionality. New Feature Label for a new feature in FHIR OSS Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Sep 23, 2023
@fhibf fhibf added this to the S124 milestone Sep 23, 2023
@fhibf fhibf requested a review from a team as a code owner September 23, 2023 01:29
@fhibf
Update Healthcase Shared components to 7.0.20.
91808a2 
Update Health Check to follow the same standards as DICOM service.
brendankowitz
brendankowitz previously approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@brendankowitz brendankowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

jnlycklama
jnlycklama previously approved these changes Sep 26, 2023
View reviewed changes
@fhibf
Updating error codes.
45e5867 
Reusing method to identify selected data store.
LTA-Thinking
LTA-Thinking previously approved these changes Sep 28, 2023
View reviewed changes
@fhibf fhibf merged commit 2742a05 into main Sep 29, 2023
@fhibf fhibf deleted the personal/fhibf/healthCheckSignals branch September 29, 2023 05:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@brendankowitz brendankowitz brendankowitz approved these changes

@jnlycklama jnlycklama jnlycklama left review comments

@LTA-Thinking LTA-Thinking LTA-Thinking left review comments

Assignees
No one assigned
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Enhancement Enhancement on existing functionality. New Feature Label for a new feature in FHIR OSS
Projects
None yet
Milestone
S124
Development

Successfully merging this pull request may close these issues.
4 participants
@fhibf @brendankowitz @jnlycklama @LTA-Thinking