Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[CMK] Encryption configuration + New FHIR runtime configurations #3542

Merged
merged 6 commits into from
Oct 17, 2023
Merged

[CMK] Encryption configuration + New FHIR runtime configurations #3542

merged 6 commits into from
Oct 17, 2023

Conversation

fhibf
Copy link
Contributor

@fhibf fhibf commented Oct 4, 2023

New configuration classes to handle encryption.

Description

Describe the changes in this PR.

Related issues

Addresses [issue #].

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@fhibf
New FHIR runtime configurations.
63f62e9 
New configuration classes to handle encryption.
@fhibf fhibf requested a review from a team as a code owner October 4, 2023 23:57
@fhibf fhibf changed the title [Do not review] Encryption configuration + New FHIR runtime configurations [CMK] Encryption configuration + New FHIR runtime configurations Oct 8, 2023
@fhibf fhibf added Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs New Feature Label for a new feature in FHIR OSS labels Oct 8, 2023
@fhibf fhibf added this to the S125 milestone Oct 8, 2023
mikaelweave
mikaelweave reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions on this PR

mikaelweave
mikaelweave approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@mikaelweave mikaelweave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (pending test execution)! 🦾

@fhibf fhibf merged commit 1cf0345 into main Oct 17, 2023
@fhibf fhibf deleted the personal/fhibf/newFhirRuntimeConfigurations branch October 17, 2023 22:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mikaelweave mikaelweave mikaelweave approved these changes

Assignees
No one assigned
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs New Feature Label for a new feature in FHIR OSS
Projects
None yet
Milestone
S125
Development

Successfully merging this pull request may close these issues.
2 participants
@fhibf @mikaelweave