Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removes Sql Schema Versions (7,8,9,10) #3578

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

mahajan-xor
Copy link
Contributor

Description

This PR removes older sql schema versions (7.sql,58.sql,9.sql,10.sql).

Also removed below class files under Features.Storage.TvpRowGeneration folder to solve build error issues
1.CompartmentAssignmentV1RowGenerator 2.DateTimeSearchParameterV1RowGenerator 3.NumberSearchParameterV1RowGenerator 4.QuantitySearchParameterV1RowGenerator 5.ReferenceSearchParameterV2RowGenerator 6.ReferenceTokenCompositeSearchParameterV2RowGenerator 7.ResourceWriteClaimV1RowGenerator 8.StringSearchParameterV1RowGenerator 9.TokenDateTimeCompositeSearchParameterV1RowGenerator 10.TokenNumberNumberCompositeSearchParameterV1RowGenerator 11.TokenQuantityCompositeSearchParameterV1RowGenerator 12.TokenSearchParameterV1RowGenerator 13.TokenStringCompositeSearchParameterV1RowGenerator 14.TokenTextSearchParameterV1RowGenerator 15.TokenTokenCompositeSearchParameterV1RowGenerator 16.UriSearchParameterV1RowGenerator

Addresses [user story #].
User Story 104513: Remove old schema versions from FHIR solution

Testing

Describe how this change was tested.

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@mahajan-xor mahajan-xor added Enhancement-Refactor Refactor on existing functionality. Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR labels Oct 31, 2023
@mahajan-xor mahajan-xor added this to the S124 milestone Oct 31, 2023
@mahajan-xor mahajan-xor requested a review from a team as a code owner October 31, 2023 14:14
Copy link
Contributor

@SergeyGaluzo SergeyGaluzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@SergeyGaluzo
Copy link
Contributor

Please remove all versions up to 60. Versions can be still present in SchemaVersion.cs.

@mahajan-xor
Copy link
Contributor Author

Please remove all versions up to 60. Versions can be still present in SchemaVersion.cs.

Yes @SergeyGaluzo I will remove all versions up to 60 . But I'm doing it in chunks because it is getting lot of issues when I try to delete all files at once. So I'm deleting 5 to 10 versions at time and solving build issues after that raising PR for same. Same approach I have discussed and finalized with Brendan and Robert.

@mahajan-xor mahajan-xor reopened this Oct 31, 2023
@SergeyGaluzo SergeyGaluzo dismissed their stale review October 31, 2023 18:20

revoking review

@mahajan-xor mahajan-xor merged commit dc257d6 into main Nov 1, 2023
@mahajan-xor mahajan-xor deleted the personal/anilm/fhiroldschemacleanup branch November 1, 2023 07:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Azure API for FHIR Label denotes that the issue or PR is relevant to the Azure API for FHIR Enhancement-Refactor Refactor on existing functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants