-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Parallel Cosmos Export #3584
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Microsoft.Health.Fhir.Core/Features/Operations/Export/ExportProcessingJob.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.CosmosDb/Features/Operations/Export/CosmosExportOrchestratorJob.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.CosmosDb/Features/Operations/Export/CosmosExportOrchestratorJob.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core.UnitTests/Features/Operations/Export/ExportProcessingJobTests.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Core.UnitTests/Features/Operations/Export/ExportProcessingJobTests.cs
Outdated
Show resolved
Hide resolved
...osoft.Health.Fhir.Shared.Tests.Integration/Features/Operations/Export/CosmosDbExportTests.cs
Outdated
Show resolved
Hide resolved
...soft.Health.Fhir.CosmosDb.UnitTests/Features/Operations/Export/ExportOrchestratorJobTests.cs
Outdated
Show resolved
Hide resolved
LTA-Thinking
approved these changes
Jan 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Azure API for FHIR
Label denotes that the issue or PR is relevant to the Azure API for FHIR
Enhancement
Enhancement on existing functionality.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds parallel export to CosmosDB by resource type and feed range. This export does not work like SQL because CosmosDB doesn't work like SQL. It's costly to get date ranges in CosmosDB
Performance is >100K resources per second on a 100K RU CosmosDB wth 300 million documents. 20 node P2V2 App Service. Exporting history gets closer to 200K resources per second.
Related issues
Addresses AB112054.
Testing
LOTS of local testing and testing in Azure OSS. I've mainly been testing with 50 million docs in my CosmosDB.
Xoriant has also been testing with a 300 million doc db.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)